New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615968 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser becomes unresponsive on exiting fullscreen

Reported by lpa...@etouch.net, May 31 2016

Issue description

Chrome Version: 53.0.2753.0 (Official Build) bb0c85e1aaa882aa7c4c40b0e3da609573f07d8f-refs/heads/master@{#396745}  (32/64-bit)
OS: Windows(7,8,8.1,10)

Steps:
1. Launch chrome and open NTP >> Wrench menu >> More tools >> Save page(Do not click it)
2. Keep F11 pressed and simultaneously click on "Save page" option
3. Close the "Save page" window and retrieve the full screen.
4. Observe

Actual:   Browser becomes unresponsive.
Expected: Browser should not go unresponsive and should function properly.

This is a regression issue broken in 'M-51'.

Manual Regression Range:
Good Build: 51.0.2679.0
Bad Build:  51.0.2680.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/3d4739bb5b1c47ed4e9eb0ee25963093ad5fc6d5..3956fa1cac34dd5682c271d77463accdd7191102?pretty=fuller&n=1000

Note: This issue is not seen on Mac OS (10.10.5, 10.11.4) and Linux (14.04 LTS)

Suspecting: r381281?
 
Actual_SavePage.mp4
511 KB Download
Expected_SavePage.mp4
513 KB Download

Comment 1 by lpa...@etouch.net, May 31 2016

Issue is also reproducible on Dev Build (52.0.2743.19)

Comment 2 by sigbjo...@opera.com, May 31 2016

Can reproduce, but I don't see how a renderer-level change to script-loading error handling can lock up the UI like that.

Comment 3 by sigbjo...@opera.com, May 31 2016

Cc: sigbjo...@opera.com
Owner: lpa...@etouch.net
Reproduces with r381281 reverted.

Verified not to be r381278 either, but (speculating freely here) r381285 perchance?
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this needs to bisect before M53 goes to stable.

Comment 5 by x...@chromium.org, May 31 2016

This is very unlikely to be r381285. 

r381285 is all about IPC messages that the cast receiver sends to the browser process. This receiver in Chrome is now only used by cast demo extension or testing. 

Comment 6 by x...@chromium.org, May 31 2016

Cc: x...@chromium.org

Comment 7 Deleted

Comment 8 by lpa...@etouch.net, Jun 1 2016

Cc: x...@chromium.org ashej...@chromium.org sigbjo...@opera.com nyerramilli@chromium.org
Components: UI>Settings
Labels: ReleaseBlock-Stable M-51 hasbisect OS-Windows
Status: Assigned
With response to comment #5: rebisected and found a different narrow bisect range
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/1fd3377af4f809442d49b63d10ba3467a64a27ff..974fa818537a8d00fb3537a836db79e2539a7889?pretty=fuller&n=1000

Suspecting: r381235?

@tdanderson: Kindly help to reassign if this is not the cause of your change.
Components: UI>Browser>FullScreen
Cc: tdander...@chromium.org
Owner: lpa...@etouch.net
Can you please clarify the repro steps here? Based on the description given in #0 and watching the video I have no idea how you can even get into a state where the browser becomes fullscreen when the "Save page as..." dialog opens. From what I can tell from trying out Windows canary, when the browser is fullscreen there is no way for me to even open the wrench menu in the first place.

In the meanwhile, it would be helpful if someone cc'ed who uses Windows to develop could quickly check if r381235 is indeed responsible - you'd only need to revert the few lines changed in BrowserView::IsTabStripVisible(), the ash/mash files are not applicable to Windows.
It reproduced for me with r381235 reverted (on Windows.)

Comment 12 by ajha@chromium.org, Jun 6 2016

lpanse@: Could you please update the thread as per C#10.

Comment 13 by lpa...@etouch.net, Jun 6 2016

Owner: tdander...@chromium.org
@tdanderson: The steps which lead to this issue remain unchanged. As per comment #10 make sure when you keep 'F11' pressed and click 'Save page as..', the browser should get into a state where Full screen is enabled and even the 'Save Page as..' window is open. After closing the 'Save Page as..' window, the browser should still remain full screened. Only then after retrieving from full screen (Press F11 to exit full screen) does the browser become unresponsive. The issue will not reproduce if the browser doesn't get into that state.

As per my understanding, this issue would probably be happening when the wrench menu click occurs after the browser transitions to full screen (which chrome doesn't allow). Hope this helps to repro the issue. Thanks.
Labels: -ReleaseBlock-Stable
Owner: ----
Status: Available (was: Assigned)
I'm still not able to reproduce on canary based on these instructions. As mentioned in #11 this issue reproduces with r381235 reverted, so my CL is not to blame (and nothing else in your bisect range looks like it could be a suspect).

Based on the fact that two disjoint bisect ranges have been given (in #0 and #8), my best guess is that this is a longer-standing issue with unreliable repro steps rather than a recent regression.

Either way, I don't think this is a stable-blocker, so I am going to remove that label.
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 6 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -ashej...@chromium.org
Components: -UI>Settings
This does not look Settings related.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***UI Mass Triage ***

Still able to reproduce the issue on windows 10 using chrome latest canary-72.0.3622.0 . As it is non regression issue adding respective labels.
Thanks..!

Sign in to add a comment