Uninit read in EventLatencyOSMouseWheelHistogram unit test |
||
Issue descriptionIn r396490, the MSG used in EventTest.EventLatencyOSMouseWheelHistogram is not properly initialized, and DrMemory complains: https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/7358 UNINITIALIZED READ: reading register ecx # 0 USER32.dll!gapfnScSendMessage +0x1ce (0x750d6196 <USER32.dll+0x16196>) # 1 USER32.dll!ScreenToClient +0x13 (0x750e2291 <USER32.dll+0x22291>) # 2 events.dll!ui::EventLocationFromNative [ui\events\win\events_win.cc:250] # 3 events.dll!ui::LocatedEvent::LocatedEvent [ui\events\event.cc:432] # 4 events.dll!ui::MouseEvent::MouseEvent [ui\events\event.cc:460] # 5 events.dll!ui::MouseWheelEvent::MouseWheelEvent [ui\events\event.cc:605] # 6 ui::EventTest_EventLatencyOSMouseWheelHistogram_Test::TestBody [ui\events\event_unittest.cc:925] # 7 testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2458] Note: @0:00:09.360 in thread 3776 Note: instruction: test %ecx %ecx Suppression (error hash=#447C0707F2888654#): For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the- { UNINITIALIZED READ name=<insert_a_suppression_name_here> USER32.dll!gapfnScSendMessage USER32.dll!ScreenToClient events.dll!ui::EventLocationFromNative events.dll!ui::LocatedEvent::LocatedEvent events.dll!ui::MouseEvent::MouseEvent events.dll!ui::MouseWheelEvent::MouseWheelEvent *!ui::EventTest_EventLatencyOSMouseWheelHistogram_Test::TestBody *!testing::internal::HandleExceptionsInMethodIfSupported<> }
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c11f4fa6d44be764cf167084cad1a2762f8e7cbf commit c11f4fa6d44be764cf167084cad1a2762f8e7cbf Author: thestig <thestig@chromium.org> Date: Tue May 31 18:58:00 2016 Properly initial a MSG struct in EventTest. BUG= 615941 TBR=sadrul@chromium.org,sahel@chromium.org Review-Url: https://codereview.chromium.org/2021193002 Cr-Commit-Position: refs/heads/master@{#396880} [modify] https://crrev.com/c11f4fa6d44be764cf167084cad1a2762f8e7cbf/ui/events/event_unittest.cc
,
May 31 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, May 31 2016Status: Started (was: Untriaged)