New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615909 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2016
Cc:
█ olka@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

AudioRendererSinkCacheTest.SmokeTest times out with DrMemory

Project Member Reported by thestig@chromium.org, May 30 2016 
Similar to  bug 615543 , but r396720 did not fix it. A couple of sample runs:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4940 with r396655

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/4957 with r396744

AudioRendererSinkCacheTest.SmokeTest:

GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: Stop()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

...

c:\b\build\slave\drm-cr\build\src\media\base\test_helpers.cc(122): error: Failed
Timed out waiting for message loop to quit
c:\b\build\slave\drm-cr\build\src\media\base\test_helpers.cc(105): error: Value of: signaled_
Actual: false
Expected: true
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a59bfc826308f7bb5abedf4106224daca03f646c

commit a59bfc826308f7bb5abedf4106224daca03f646c
Author: thestig <thestig@chromium.org>
Date: Tue May 31 00:11:28 2016

DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest.

BUG= 615909 
TBR=olka@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2024733002
Cr-Commit-Position: refs/heads/master@{#396758}

[modify] https://crrev.com/a59bfc826308f7bb5abedf4106224daca03f646c/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bed9640236347f95a090060c024c549be198239

commit 9bed9640236347f95a090060c024c549be198239
Author: olka <olka@chromium.org>
Date: Thu Jun 02 09:32:17 2016

Extending timeout for AudioRendererSinkCacheTest.SmokeTest
It accesses memory heavily, so it takes longer with DrMemory.

BUG= 615909 

Review-Url: https://codereview.chromium.org/2021273002
Cr-Commit-Position: refs/heads/master@{#397350}

[modify] https://crrev.com/9bed9640236347f95a090060c024c549be198239/content/renderer/media/audio_renderer_sink_cache_unittest.cc
[modify] https://crrev.com/9bed9640236347f95a090060c024c549be198239/media/base/test_helpers.cc
[modify] https://crrev.com/9bed9640236347f95a090060c024c549be198239/media/base/test_helpers.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9af040a364c15bdc2adeea794e173a2c529a3ddc

commit 9af040a364c15bdc2adeea794e173a2c529a3ddc
Author: olka <olka@chromium.org>
Date: Thu Jun 02 10:55:38 2016

Revert of DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest. (patchset #2 id:20001 of https://codereview.chromium.org/2024733002/ )

Reason for revert:
Fix for timeout extension has landed https://codereview.chromium.org/2021273002, re-enabling the test.

Original issue's description:
> DrMemory: Disable AudioRendererSinkCacheTest.SmokeTest.
>
> BUG= 615909 
> TBR=olka@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/a59bfc826308f7bb5abedf4106224daca03f646c
> Cr-Commit-Position: refs/heads/master@{#396758}

TBR=thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 615909 

Review-Url: https://codereview.chromium.org/2034633003
Cr-Commit-Position: refs/heads/master@{#397359}

[modify] https://crrev.com/9af040a364c15bdc2adeea794e173a2c529a3ddc/tools/valgrind/gtest_exclude/content_unittests.gtest-drmemory_win32.txt

Comment 4 by yini...@chromium.org, Jun 3 2016

Status: Assigned (was: Untriaged)

Comment 5 by olka@chromium.org, Jun 8 2016

Owner: yini...@chromium.org
Could you please provide more info?

Comment 6 by olka@chromium.org, Jun 8 2016

Cc: olka@chromium.org

Comment 7 by yini...@chromium.org, Jun 8 2016

Owner: ----
Status: Untriaged (was: Assigned)
olka@, I don't know why this bug was assigned to me. Isn't it fixed already as per #6? if so, can you close it?

Comment 8 by olka@chromium.org, Jun 8 2016

Status: Fixed (was: Untriaged)
I closed it, but it was re-opened by you on June 3, so I thought there was some problem:) ok, np
►

Sign in to add a comment