New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615904 link

Starred by 1 user
Status: Fixed
Owner:
█ nek...@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Unable to click on images inside links using Jaws

Project Member Reported by nek...@chromium.org, May 30 2016 
With Jaws:
1. Browse to https://www.umart.com.au/
2. Select the first store location if prompted.
3. Using Jaws' virtual cursor, navigate to any product and click the "Add to cart" link.
4. Observe that nothing is added to your cart.

With NVDA:
1. Browse to https://www.umart.com.au/
2. Select the first store location if prompted.
3. Use the Review cursor (using the numeric keypad) to find any of the "Add to cart" links and then drill down to the graphic inside the link.
4. Open the NVDA Console and try to execute the "accDoDefaultAction" method on the "nav" object. (The "nav" object is the object at the location of the Review Cursor.)
nav.IAccessibleObject.accDoDefaultAction()
5. Observe that even though S_OK is returned, nothing is added to your cart.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cff44e1023869434c07689e29ee4440a3b7a2e

commit d4cff44e1023869434c07689e29ee4440a3b7a2e
Author: nektar <nektar@chromium.org>
Date: Wed Jun 01 19:43:36 2016

Make click targets inside links work.

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG= 615904 
R=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2021953002
Cr-Commit-Position: refs/heads/master@{#397211}

[add] https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e/third_party/WebKit/LayoutTests/accessibility/image-inside-link.html
[modify] https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Comment 2 by nek...@chromium.org, Jun 1 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9

commit d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9
Author: jbroman <jbroman@chromium.org>
Date: Thu Jun 02 15:36:13 2016

Revert of Make click targets inside links work. (patchset #4 id:60001 of https://codereview.chromium.org/2021953002/ )

Reason for revert:
Flakily timing out:
https://bugs.chromium.org/p/chromium/issues/detail?id=616768

Original issue's description:
> Make click targets inside links work.
>
> There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
> For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
> BUG= 615904 
> R=dmazzoni@chromium.org
>
> Committed: https://crrev.com/d4cff44e1023869434c07689e29ee4440a3b7a2e
> Cr-Commit-Position: refs/heads/master@{#397211}

TBR=dmazzoni@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615904 , 616768 

Review-Url: https://codereview.chromium.org/2035583003
Cr-Commit-Position: refs/heads/master@{#397416}

[delete] https://crrev.com/82a7b410387ac390eb1cae7b96fa7b19849448eb/third_party/WebKit/LayoutTests/accessibility/image-inside-link.html
[modify] https://crrev.com/d86069ee9b4f00d97d5658f3fd2a9b3842b15bb9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f491eb9a53ed36e90ab45c943a0e52247ec00da5

commit f491eb9a53ed36e90ab45c943a0e52247ec00da5
Author: nektar <nektar@chromium.org>
Date: Fri Jun 03 18:21:49 2016

Make click targets inside links work.

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG= 615904 
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2030413002
Cr-Commit-Position: refs/heads/master@{#397760}

[add] https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5/third_party/WebKit/LayoutTests/accessibility/image-inside-link.html
[modify] https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4904fc8910dc86a23596f7a9e39960ad2635a37b

commit 4904fc8910dc86a23596f7a9e39960ad2635a37b
Author: jbroman <jbroman@chromium.org>
Date: Fri Jun 03 19:55:43 2016

Revert of Make click targets inside links work. (patchset #1 id:1 of https://codereview.chromium.org/2030413002/ )

Reason for revert:
Failing on Mac 10.11 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/2237

Error message is:

Harness Error. harness_status.status = 2 , harness_status.message = null

Sorry to revert this again. :(

Original issue's description:
> Make click targets inside links work.
>
> There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
> For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
> BUG= 615904 
> TBR=dmazzoni@chromium.org
>
> Committed: https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5
> Cr-Commit-Position: refs/heads/master@{#397760}

TBR=dmazzoni@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615904 

Review-Url: https://codereview.chromium.org/2036943003
Cr-Commit-Position: refs/heads/master@{#397782}

[delete] https://crrev.com/ff86e347c0030f96d3beefec7bb3de7caf882371/third_party/WebKit/LayoutTests/accessibility/image-inside-link.html
[modify] https://crrev.com/4904fc8910dc86a23596f7a9e39960ad2635a37b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b474d37feaa57c430c28477b5aab38f65ff4d9c0

commit b474d37feaa57c430c28477b5aab38f65ff4d9c0
Author: nektar <nektar@chromium.org>
Date: Sat Jun 04 01:25:33 2016

Make click targets inside links work.

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG= 615904 
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2043433002
Cr-Commit-Position: refs/heads/master@{#397882}

[add] https://crrev.com/b474d37feaa57c430c28477b5aab38f65ff4d9c0/third_party/WebKit/LayoutTests/accessibility/image-inside-link.html
[modify] https://crrev.com/b474d37feaa57c430c28477b5aab38f65ff4d9c0/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
►

Sign in to add a comment