Progress:
1. Removed the "Go Incognito button";
2. Re-designed the string and icon of the button "Switch person" to be "Manage people".
Related CLs: 2018643002, 2028473002, 2019053002

Deleted: Screenshot from 2016-05-30 17:47:53.png 27.5 KB

	Screenshot from 2016-05-30 17:47:53.png 27.5 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5601bd63e3623961b7afc85e8cb2e77d60d0c694

commit 5601bd63e3623961b7afc85e8cb2e77d60d0c694
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Jun 02 14:34:08 2016

Creates a flag to be used for the desktop user menu revamp project.
Testing was done on the chrome://flags page as well as to use switches::IsRedesignedDesktopUserMenu().

BUG= 615893 

Review-Url: https://codereview.chromium.org/2031763002
Cr-Commit-Position: refs/heads/master@{#397395}

[modify] https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694/chrome/app/generated_resources.grd
[modify] https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694/chrome/browser/about_flags.cc
[modify] https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694/components/signin/core/common/profile_management_switches.cc
[modify] https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694/components/signin/core/common/profile_management_switches.h
[modify] https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694/components/signin/core/common/signin_switches.cc
[modify] https://crrev.com/5601bd63e3623961b7afc85e8cb2e77d60d0c694/components/signin/core/common/signin_switches.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a592811157d54d1f0fea98de73323f908a0b289c

commit a592811157d54d1f0fea98de73323f908a0b289c
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Jun 02 15:47:38 2016

Added two new icons for user menu.

See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.abdhimh1kvzb

These two icons are to be used for the "Manage people" button as well as the sync error icon displayed on titlebar. See how they will be used here: https://codereview.chromium.org/2019053002/

BUG= 615893 

Review-Url: https://codereview.chromium.org/2028473002
Cr-Commit-Position: refs/heads/master@{#397422}

[modify] https://crrev.com/a592811157d54d1f0fea98de73323f908a0b289c/ui/gfx/BUILD.gn
[add] https://crrev.com/a592811157d54d1f0fea98de73323f908a0b289c/ui/gfx/vector_icons/settings.icon
[add] https://crrev.com/a592811157d54d1f0fea98de73323f908a0b289c/ui/gfx/vector_icons/sync_problem.icon

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b877548e091c72b836324d65c4714e7461b53a45

commit b877548e091c72b836324d65c4714e7461b53a45
Author: janeliulwq <janeliulwq@google.com>
Date: Mon Jun 06 22:20:47 2016

Changed two icons for desktop user menu on Linux/Windows:
1. Changed the icon for the "Manage people" button;
2. Changed the icon for sync error on the titlebar.

See design doc here: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

This CL is dependent on https://codereview.chromium.org/2028473002/

BUG= 615893 

Review-Url: https://codereview.chromium.org/2019053002
Cr-Commit-Position: refs/heads/master@{#398141}

[modify] https://crrev.com/b877548e091c72b836324d65c4714e7461b53a45/chrome/browser/ui/views/profiles/new_avatar_button.cc
[modify] https://crrev.com/b877548e091c72b836324d65c4714e7461b53a45/chrome/browser/ui/views/profiles/profile_chooser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5824d7906802051e8c2193b05b83cb44494379ae

commit 5824d7906802051e8c2193b05b83cb44494379ae
Author: janeliulwq <janeliulwq@google.com>
Date: Tue Jun 07 01:09:17 2016

Previous code change 2018643002 (for user menu redesign) modified code on the spot and did not put the changes behind any flag. This CL is to:
1. add flags for the previous code change;
2. add back some of the deleted resources as they will still be used when the flag is not turned on.

BUG= 615893 

Review-Url: https://codereview.chromium.org/2034093003
Cr-Commit-Position: refs/heads/master@{#398184}

[modify] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/app/generated_resources.grd
[add] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/app/theme/default_100_percent/common/incognito.png
[add] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/app/theme/default_200_percent/common/incognito.png
[modify] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
[modify] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/5824d7906802051e8c2193b05b83cb44494379ae/chrome/browser/ui/views/profiles/profile_chooser_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a96c46f7536d7dcd037738eb5cb8d653c8ef857

commit 0a96c46f7536d7dcd037738eb5cb8d653c8ef857
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jun 29 00:08:02 2016

Specifically:
1. Migrated the fast user switching buttons triggered by right clicks back to user menu's main page
2. Added a "Guest" button
3. Added a "Close all your windows" button
4. Made UI modifications such as circular icons, paddings, etc.

See screenshot:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGY2tBWklPOFVKS28/view?usp=sharing

Mockup:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-2.png (Note the appropriate icons for "Guest" and "Close all your windows" will be added as a separate CL.)

BUG= 615893 

Review-Url: https://codereview.chromium.org/2057203002
Cr-Commit-Position: refs/heads/master@{#402607}

[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/app/generated_resources.grd
[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/browser/profiles/profile_avatar_icon_util.cc
[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/browser/profiles/profile_avatar_icon_util.h
[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/browser/profiles/profile_window.h
[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/0a96c46f7536d7dcd037738eb5cb8d653c8ef857/chrome/browser/ui/views/profiles/profile_chooser_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a67c7464a9e96032efd3adff31226aae06507a8

commit 7a67c7464a9e96032efd3adff31226aae06507a8
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Jun 30 02:22:00 2016

Added/replaced icons in material design user menu

Specifically:

1. Added account_circle.icon and used it for the guest profile button in the user menu
2. Added close_all.icon and used it for "Close all your windows" button in the user menu

See mocks here:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-1.png

BUG= 615893 

Review-Url: https://codereview.chromium.org/2105863005
Cr-Commit-Position: refs/heads/master@{#403071}

[modify] https://crrev.com/7a67c7464a9e96032efd3adff31226aae06507a8/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/7a67c7464a9e96032efd3adff31226aae06507a8/ui/gfx/BUILD.gn
[add] https://crrev.com/7a67c7464a9e96032efd3adff31226aae06507a8/ui/gfx/vector_icons/account_circle.icon
[add] https://crrev.com/7a67c7464a9e96032efd3adff31226aae06507a8/ui/gfx/vector_icons/close_all.icon

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9860fa8491d8f794cfeaa0f05d7240d3d89357e

commit f9860fa8491d8f794cfeaa0f05d7240d3d89357e
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Jun 30 16:15:31 2016

Reflow of the profile items in desktop user menu. Specifically:
1. Moved and resized the avatar icon as well as icon badges
1. Moved avatar name up to be on the right of the profile icon
2. Moved username and "Your accounts" link up and below the avatar name
3. Other dimension and padding changes

See design doc here ("Reflow the items in the first section"): https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

See redlines here:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#

See screenshots here (marked with "3.*"):
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGY2NrSEhheHptdG8

Downstream CL: https://codereview.chromium.org/2052473003/

BUG= 615893 

Review-Url: https://codereview.chromium.org/2023093002
Cr-Commit-Position: refs/heads/master@{#403190}

[modify] https://crrev.com/f9860fa8491d8f794cfeaa0f05d7240d3d89357e/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/f9860fa8491d8f794cfeaa0f05d7240d3d89357e/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/f9860fa8491d8f794cfeaa0f05d7240d3d89357e/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/478d83e5b642df214eea6a01d8a3a46b6b44cf1c

commit 478d83e5b642df214eea6a01d8a3a46b6b44cf1c
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 06 16:56:52 2016

Reflow of user menu's active profile card into a button

Reflowed the top section of the user menu (i.e. where the profile icon and avatar name are displayed) into a button that leads to chrome://settings/manageProfile.

See screenshots (marked with 4.*:
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGY2NrSEhheHptdG8

Mockup:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-2.png

Upstream CL (landed):
https://codereview.chromium.org/2023093002/

BUG= 615893 

Review-Url: https://codereview.chromium.org/2052473003
Cr-Commit-Position: refs/heads/master@{#403919}

[modify] https://crrev.com/478d83e5b642df214eea6a01d8a3a46b6b44cf1c/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/478d83e5b642df214eea6a01d8a3a46b6b44cf1c/chrome/browser/ui/views/profiles/profile_chooser_view.h

Could some one please help us with the scenarios which needs to be verified so that test team can triage this if required.

Thanks.! 

Hi ranjitkan@, we're tracking the launch associated with these changes in Issue 616242. Once we've finished all the eng work, I'll flip that launch to "Review-requested" and fill out the test survey.

Thanks!

Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13628d49e1290169aa763ea3e63ac6c5adb94472

commit 13628d49e1290169aa763ea3e63ac6c5adb94472
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 13 01:16:49 2016

Margin tweaks in the desktop user menu UI
Specifically:
1. Horizontal margin tweak in the supervised user disclaimer view
2. Vertical margin tweak in the profile card to center the avatar name / username better

See mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fpreview-2.png

See comparative screenshots: https://drive.google.com/a/google.com/folderview?id=0B7Fvv7JszRyGU05yWTRIUVp4OFE&usp=sharing

BUG= 615893 

Review-Url: https://codereview.chromium.org/2142173002
Cr-Commit-Position: refs/heads/master@{#404871}

[modify] https://crrev.com/13628d49e1290169aa763ea3e63ac6c5adb94472/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Progress update:
1. Added a flag for enabling material design user menu on desktop, #show-material-design-user-menu;
2. (Linux/Windows) Reflowed the profile card into a button that leads to chrome://settings/manageProfile;
3. (Linux/Windows) Added the fast user switching buttons back to the left-click menu;
4. (Linux/Windows) Small changes to the option buttons: added a "Close all your windows" button for non-guest users when there is more than one window open and supervised account doesn't exist; changed "Switch person" button to "Manage people"; removed "Go incognito" button.

Deleted: flag.png 27.2 KB

	flag.png 27.2 KB View Download

Deleted: Sign-in user.png 38.6 KB

	Sign-in user.png 38.6 KB View Download

Deleted: Supervised user with multiple windows.png 37.0 KB

	Supervised user with multiple windows.png 37.0 KB View Download

Deleted: Not signed-in.png 39.6 KB

	Not signed-in.png 39.6 KB View Download

Deleted: Signed-in user with account consistency mode.png 39.1 KB

	Signed-in user with account consistency mode.png 39.1 KB View Download

Looking great, thanks for the update Jane. In the "Not signed-in" screenshot, it looks like the button isn't quite left-aligned with the text. Is that intended?

There was no extra spacing coded in; I think that little misalignment just has to do with how the button itself is drawn. If you take a look at the signin button in the current user menu, it also looks like there is a little misalignment on the left with the text above. 
I can always move the button a bit, but it wouldn't be very clean to do so.

Got it, okay, thanks for the explanation. No need to move the button, we'll run it by Chris/Alan when we're mostly finished and ready for them to do a full UX pass to make sure it's okay

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37bd798e002dd4a0830927024695c953f86bea76

commit 37bd798e002dd4a0830927024695c953f86bea76
Author: mahmadi <mahmadi@chromium.org>
Date: Thu Jul 14 21:12:55 2016

Makes 'Disconnect Account' overlay in chrome://settings accessible thru a URL

BUG= 615893 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2136103008
Cr-Commit-Position: refs/heads/master@{#405570}

[modify] https://crrev.com/37bd798e002dd4a0830927024695c953f86bea76/chrome/app/generated_resources.grd
[modify] https://crrev.com/37bd798e002dd4a0830927024695c953f86bea76/chrome/browser/resources/options/manage_profile_overlay.js
[modify] https://crrev.com/37bd798e002dd4a0830927024695c953f86bea76/chrome/browser/resources/options/options.js
[modify] https://crrev.com/37bd798e002dd4a0830927024695c953f86bea76/chrome/browser/ui/webui/options/manage_profile_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58a786ba513d0dec06fea96f0ec684a60aa50a08

commit 58a786ba513d0dec06fea96f0ec684a60aa50a08
Author: janeliulwq <janeliulwq@google.com>
Date: Tue Jul 19 21:01:08 2016

Reflowed the profile card in mac desktop user menu into a button (for material design user menu).
Implemented with createMaterialDesignCurrentProfileView, which is based on/parallel to createCurrentProfileView.
Specifically:
1. Reduced the size of profile icon and moved it to be left-aligned
2. Placed avatar name and username to the right of the profile icon
3. Changed account consistency link to be a button instead
4. Consolidated the profile info into a profile card button that leads to manageProfile in the settings page
5. Other layout tweaks

See design doc: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xesoh23gozz

Screenshots: https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGOG9yOTl3bkJQVjQ

Mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fpreview-2.png

BUG= 615893 

Review-Url: https://codereview.chromium.org/2136943003
Cr-Commit-Position: refs/heads/master@{#406377}

[modify] https://crrev.com/58a786ba513d0dec06fea96f0ec684a60aa50a08/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1831391aeba23ff66f87678b619ddee6113066d2

commit 1831391aeba23ff66f87678b619ddee6113066d2
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 20 01:37:55 2016

Excluded non-chromeos source files in chromeos build
Excluded profile_chooser_view and profile_signin_confirmation_dialog_views in chromeos builds because they are desktop-only views.
Building them in chromeos prevents them from using desktop-only functions. For an example, see the build failures in https://codereview.chromium.org/2151513002/#ps100001.
Tested by applying the above patch and verifying that the build passes.

BUG= 615893 

Review-Url: https://codereview.chromium.org/2148293003
Cr-Commit-Position: refs/heads/master@{#406443}

[modify] https://crrev.com/1831391aeba23ff66f87678b619ddee6113066d2/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
[modify] https://crrev.com/1831391aeba23ff66f87678b619ddee6113066d2/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/1831391aeba23ff66f87678b619ddee6113066d2/chrome/browser/ui/views/tab_dialogs_views.cc
[modify] https://crrev.com/1831391aeba23ff66f87678b619ddee6113066d2/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/1831391aeba23ff66f87678b619ddee6113066d2/chrome/chrome_tests.gypi
[modify] https://crrev.com/1831391aeba23ff66f87678b619ddee6113066d2/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1adbbce30aaff8ea555181506404bac76de99ff6

commit 1adbbce30aaff8ea555181506404bac76de99ff6
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 20 02:18:47 2016

User menu button icon tweaks
This is for material design desktop user menu only. Specifically:
1. Tweaked the icon-title spacing in option buttons;
2. Changed the "Exit Guest" icon.

See mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-1.png%3Fc=show (Comment #8 discusses these tweaks.)
See comparative screenshots: https://drive.google.com/a/google.com/folderview?id=0B7Fvv7JszRyGZnlYMzc2QnJMbzA&usp=sharing

BUG= 615893 

Review-Url: https://codereview.chromium.org/2159233002
Cr-Commit-Position: refs/heads/master@{#406464}

[modify] https://crrev.com/1adbbce30aaff8ea555181506404bac76de99ff6/chrome/browser/ui/views/profiles/profile_chooser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8377f1c3a69342cdedf56368e25387d3fcaad2ec

commit 8377f1c3a69342cdedf56368e25387d3fcaad2ec
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 20 03:12:30 2016

Revamped signin/sync error surfacing on desktop user menu
This is for material design user menu on windows/linux only.

Specifically:
1. Created a new UI for error surfacing that sits above the user menu (instead of the current email badging UI);
2. Funneled all signin- and sync-related errors through this UI: unrecoverable errors, auth errors, out-of-date-client error, and passphrase error. See the detailed list of errors and their designed behavior here: https://docs.google.com/document/d/1jEzY44oMWenzJQUIBf1x8dkkqm2PJbYngvQzeXTMkLc/edit#heading=h.o6ftotuznu1h
3. Removed the blue tutorial headers for the user menu because the existing tutorial modes will be either no longer applicable in MD or migrated into another UI, and we are not planning to add new modes.

Other useful links:
- The error detection logic roughly follows the error surfacing mechanism on the settings page in this function: https://cs.chromium.org/chromium/src/chrome/browser/sync/sync_ui_util.cc?rcl=1468394226&l=151
- Screenshot: https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGUGtKaFFRMmxBSG8/view
- Mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fpreview-3.png (Don't refer to the strings there)
- Project design doc: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xrfx2rucezz

BUG= 615893 

Review-Url: https://codereview.chromium.org/2151513002
Cr-Commit-Position: refs/heads/master@{#406476}

[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/app/chromium_strings.grd
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/app/generated_resources.grd
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/browser/ui/views/profiles/new_avatar_button.cc
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/browser/ui/views/profiles/new_avatar_button.h
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/common/url_constants.cc
[modify] https://crrev.com/8377f1c3a69342cdedf56368e25387d3fcaad2ec/chrome/common/url_constants.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17508904c91aa277f580b613b36807097a67dea1

commit 17508904c91aa277f580b613b36807097a67dea1
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Jul 20 21:39:29 2016

Removed sync error menu item from the wrench menu (material design user menu only)
This is only for when #show-material-design-user-menu is enabled. For this case, sync error surfacing has been migrated to be in the user menu (https://codereview.chromium.org/2151513002/). Therefore, there shouldn't be a menu item in the wrench menu or any other surfacing UI for sync errors any more.

See project design doc: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xrfx2rucezz

BUG= 615893 

Review-Url: https://codereview.chromium.org/2168713002
Cr-Commit-Position: refs/heads/master@{#406677}

[modify] https://crrev.com/17508904c91aa277f580b613b36807097a67dea1/chrome/browser/sync/sync_global_error.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d123727f6a71838bc658c255a685fed19bd34d6e

commit d123727f6a71838bc658c255a685fed19bd34d6e
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Jul 21 14:46:46 2016

Bringing back fast user switching on Mac material design user menu
Specifically:
1. Migrated the fast user switching buttons view (triggered by right-clicking the avatar button) back to user menu's main page;
2. Added a "Guest" and "Close all your windows" button. Implemented with createMaterialDesignOptionsViewWithRect, which is based on/parallel to createOptionsViewWithRect;
3. Made UI modifications on paddings, seperators/not, using new skia icons, etc.

See screenshot:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGTndKT2pBWlhRY2s/view
Mocks:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu/specs#%2Fspec-2.png
Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.ulgws5x4kc7r

BUG= 615893 

Review-Url: https://codereview.chromium.org/2171473002
Cr-Commit-Position: refs/heads/master@{#406849}

[modify] https://crrev.com/d123727f6a71838bc658c255a685fed19bd34d6e/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3

commit e4525c4a250b0d405abaecd6ba9bae7e46bfdda3
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Aug 03 02:52:16 2016

Refactored signin/sync error controllers for the avatar button

Background:
The titlebar avatar button needs to display a warning icon when there is:
1. an auth error; or
2. a sync error, including unrecoverable errors, outdated client error, and sync
passphrase error (MD user menu only).
Its auth error controller and sync error controller previously resided in its UI
code, new_avatar_button.
Meanwhile, the MD user menu displays an error message and button for the same set
of errors, and the logic for classifying each error previously resided in its UI
code, profile_chooser_view.

In this CL, the following refactoring was done:
1. sync error controller for avatar button: from new_avatar_button to
avatar_sync_error_controller;
2. signin error controller for avatar button: from new_avatar_button to
avatar_signin_error_controller;
3. the logic for classifying different errors: from profile_chooser_view to
sync_ui_util.
They will all be used on both Linux UI (this CL) and Mac UI (followup CL).

BUG= 615893 

Review-Url: https://codereview.chromium.org/2179283002
Cr-Commit-Position: refs/heads/master@{#409439}

[modify] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/sync/sync_ui_util.h
[add] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/ui/avatar_button_error_controller.cc
[add] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/ui/avatar_button_error_controller.h
[add] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/ui/avatar_button_error_controller_delegate.h
[modify] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/ui/views/profiles/new_avatar_button.cc
[modify] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/ui/views/profiles/new_avatar_button.h
[modify] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/e4525c4a250b0d405abaecd6ba9bae7e46bfdda3/chrome/chrome_browser_ui.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c878411379d5e5c4860845f1ea7a79e353f06f71

commit c878411379d5e5c4860845f1ea7a79e353f06f71
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Aug 04 14:23:20 2016

[Mac][MD User Menu] Revamped signin/sync error surfacing UI

Specifically:
1. Created a new UI for error surfacing that sits above the user menu
(to replace the current email badging UI);
2. Funneled all signin- and sync-related errors through this UI:
unrecoverable errors, auth errors, out-of-date-client errors, and
passphrase errors. See the detailed list of errors and their designed
behavior here:
https://docs.google.com/document/d/1jEzY44oMWenzJQUIBf1x8dkkqm2PJbYngvQzeXTMkLc/edit#heading=h.o6ftotuznu1h
3. Made respective modifications to the avatar button observers so that
the button displays an error icon for these new errors too;
4. Removed the blue tutorial headers for the user menu because the
existing tutorial modes will be etiher no longer applicable in MD or
migrated into another UI (and we are not planning to add new tutorials).

Other useful links:
- Screenshot: https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGYXhRbFJTODBZWTg/view
- Mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu/specs#%2Fspec-3.png (Don't refer to the strings there)
- Project design doc: https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.6xrfx2rucezz

BUG= 615893 

Review-Url: https://codereview.chromium.org/2174973002
Cr-Commit-Position: refs/heads/master@{#409780}

[modify] https://crrev.com/c878411379d5e5c4860845f1ea7a79e353f06f71/chrome/browser/ui/cocoa/profiles/avatar_base_controller.h
[modify] https://crrev.com/c878411379d5e5c4860845f1ea7a79e353f06f71/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
[modify] https://crrev.com/c878411379d5e5c4860845f1ea7a79e353f06f71/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/c878411379d5e5c4860845f1ea7a79e353f06f71/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm
[modify] https://crrev.com/c878411379d5e5c4860845f1ea7a79e353f06f71/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2995fb57c078db3de42e5ad46faf5ad428e80d

commit bd2995fb57c078db3de42e5ad46faf5ad428e80d
Author: janeliulwq <janeliulwq@google.com>
Date: Thu Aug 11 14:29:24 2016

[Mac][MD User Menu] UI Tweaks

Specifically:
1. Fixed misalignment between user menu and avatar button (see bug #1)
2. Fixed pixelated profile icon border (see  bug #2 )
3. Fixed certain letters being cut off on the bottom for avatar name
4. Disabled the color change for button icons upon mouse down
5. Disabled focus for buttons that are disabled (see  bug #3 )

See comparative screenshots:
https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGWUtYM29OdnVjQm8

BUG= 632936 
BUG= 633175 
BUG= 633877 

BUG= 615893 

Review-Url: https://codereview.chromium.org/2197253002
Cr-Commit-Position: refs/heads/master@{#411323}

[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763815b9496d4c7bea3354e05e3d5c0969d70ba0

commit 763815b9496d4c7bea3354e05e3d5c0969d70ba0
Author: janeliulwq <janeliulwq@google.com>
Date: Fri Aug 12 14:08:29 2016

[MD User Menu] Removed the tooltips for profile buttons

Removing the tooltips for the profile switching buttons in the MD user
menu. Tooltips used to show up for long profile names.
The design rationale is to not have native tooltips for MD UI.

BUG= 615893 

Review-Url: https://codereview.chromium.org/2239443003
Cr-Commit-Position: refs/heads/master@{#411639}

[modify] https://crrev.com/763815b9496d4c7bea3354e05e3d5c0969d70ba0/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/763815b9496d4c7bea3354e05e3d5c0969d70ba0/chrome/browser/ui/views/profiles/profile_chooser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5141f56dc92d1400988bfabb5170dd48731ee4f

commit d5141f56dc92d1400988bfabb5170dd48731ee4f
Author: janeliulwq <janeliulwq@google.com>
Date: Mon Aug 15 14:40:21 2016

[MD User Menu] New profile badge icons

Added new profile badge icons (i.e. supervised icon and child icon) for
MD user menu. The new icons are inverted inside a circle to save
unnecessary drawing steps on the run and to follow the new color spec
for the icons.

Mock (icon doesn't look exactly the same):
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu/preview#%2Fpreview-2.png

Screenshot:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGZHVOdndlNXFxWXc/view?usp=sharing

BUG= 615893 

Review-Url: https://codereview.chromium.org/2242873002
Cr-Commit-Position: refs/heads/master@{#411963}

[modify] https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[rename] https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f/ui/gfx/vector_icons/account_child.icon
[add] https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f/ui/gfx/vector_icons/account_child_circle.icon
[add] https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f/ui/gfx/vector_icons/supervisor_account_circle.icon
[modify] https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f/ui/gfx/vector_icons_sources.gypi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c1b94967e6c785c92201266d539fe805ad9d0fe

commit 5c1b94967e6c785c92201266d539fe805ad9d0fe
Author: janeliulwq <janeliulwq@google.com>
Date: Fri Aug 19 22:42:19 2016

[User menu] Manually close the user menu upon signin modals

Manually close the user menu when signin tab modals get triggered from
the user menu, because signin modals don't take away focus on windows.

BUG= 615893 

Review-Url: https://codereview.chromium.org/2251343005
Cr-Commit-Position: refs/heads/master@{#413271}

[modify] https://crrev.com/5c1b94967e6c785c92201266d539fe805ad9d0fe/chrome/browser/ui/views/profiles/profile_chooser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/441da708943b005941af140a1364c0b305eafa4c

commit 441da708943b005941af140a1364c0b305eafa4c
Author: janeliulwq <janeliulwq@google.com>
Date: Tue Aug 23 16:39:47 2016

[Mac][MD User Menu] Updated the profile badge icons

Instead of using the legacy png resources, MD user menu now uses new svg
icons for profile badges for child and supervised users. A circular
background of the same color of the user menu background is drawn first,
and then the badge icon on top of it.

Screenshot: https://drive.google.com/open?id=0B7Fvv7JszRyGLWR2WG5HazRma1k

Mock (different icons though): https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu/preview#%2Fpreview-2.png

BUG= 615893 

Review-Url: https://codereview.chromium.org/2267723002
Cr-Commit-Position: refs/heads/master@{#413760}

[modify] https://crrev.com/441da708943b005941af140a1364c0b305eafa4c/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d85923b15015fff31fa7e187684b6dc559fe7b8

commit 5d85923b15015fff31fa7e187684b6dc559fe7b8
Author: janeliulwq <janeliulwq@google.com>
Date: Tue Aug 23 21:43:51 2016

[MD User Menu] New way to handle supervised user auth error

Background:
The MD user menu shows an error header when sync errors occur. For auth
errors in particular, the header prompts the user to sign in again to
resolve them. However, when the user is a supervised user, signing in is
not an option.

In this CL, we add a way to specifically handle auth errors for
supervised users, which displays a different message in the error header
and with no action button.

Screenshot: https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGaUtrbUNXVDBlR0k/view

BUG= 615893 

Review-Url: https://codereview.chromium.org/2267013002
Cr-Commit-Position: refs/heads/master@{#413847}

[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/app/chromium_strings.grd
[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/browser/sync/sync_ui_util.h
[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/5d85923b15015fff31fa7e187684b6dc559fe7b8/chrome/browser/ui/views/profiles/profile_chooser_view.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b37d9ea9bfeccc11482eb81d16ff29f84e652181

commit b37d9ea9bfeccc11482eb81d16ff29f84e652181
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Aug 24 01:03:14 2016

[MD User Menu] Updated the close_all icon

Updated the close_all icon with a newly tweaked svg source.
See first bug.

See source at: https://drive.google.com/open?id=0BxMIIGI80eU-d2Q1QXRlTnp0M2M

BUG= 640289 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2273803002
Cr-Commit-Position: refs/heads/master@{#413917}

[modify] https://crrev.com/b37d9ea9bfeccc11482eb81d16ff29f84e652181/ui/gfx/vector_icons/close_all.icon

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c21870f967d30e6bd32c1e9c55e82f345a94d53

commit 3c21870f967d30e6bd32c1e9c55e82f345a94d53
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Aug 24 01:04:35 2016

[Mac][MD User Menu] Adjusted the vertical position of icon in avatar button

Adjusted the vertical position of the error icon in MD avatar button so
that it looks vertically centered. See first bug.

BUG= 636035 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2268393002
Cr-Commit-Position: refs/heads/master@{#413918}

[modify] https://crrev.com/3c21870f967d30e6bd32c1e9c55e82f345a94d53/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7356a6799fe1970f52a499eafb914f66a3fabaf

commit d7356a6799fe1970f52a499eafb914f66a3fabaf
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Aug 24 03:17:40 2016

[Mac][MD User Menu] Fixed the accessibility string of profile button

The new profile card button needs an accessibility string since it has
no label. The string would be "Edit person, <profile name>" or "Edit
person, <profile name>, <email>" for signed in profiles. See first bug.

Tested with VoiceOver.

BUG=619725
BUG= 615893 

Review-Url: https://codereview.chromium.org/2268353003
Cr-Commit-Position: refs/heads/master@{#413965}

[modify] https://crrev.com/d7356a6799fe1970f52a499eafb914f66a3fabaf/chrome/app/generated_resources.grd
[modify] https://crrev.com/d7356a6799fe1970f52a499eafb914f66a3fabaf/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12350097b18cf5a7225a57138834ce9d62b741af

commit 12350097b18cf5a7225a57138834ce9d62b741af
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Aug 24 16:49:28 2016

[MD User Menu] Adjusted its background color

See first bug.
BUG= 636073 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2241293003
Cr-Commit-Position: refs/heads/master@{#414092}

[modify] https://crrev.com/12350097b18cf5a7225a57138834ce9d62b741af/ui/native_theme/native_theme_mac.mm
[modify] https://crrev.com/12350097b18cf5a7225a57138834ce9d62b741af/ui/native_theme/native_theme_win.cc

Progress update:
1. (Linux/Windows) Added a header on the user menu for surfacing sync errors
2. (Mac) Reflowed the profile card into a button that leads to chrome://settings/manageProfile;
3. (Mac) Added the fast user switching buttons back to the left-click menu;
4. (Mac) Added a "Close all your windows" button; changed "Switch person" button to "Manage people"; removed "Go incognito" button.

Deleted: Signed-in user with sync passphrase error.png 30.6 KB

	Signed-in user with sync passphrase error.png 30.6 KB View Download

Deleted: [Mac] Signed-in user with out-of-date signin detail error.png 51.6 KB

	[Mac] Signed-in user with out-of-date signin detail error.png 51.6 KB View Download

Deleted: [Mac] Not signed-in user.png 51.9 KB

	[Mac] Not signed-in user.png 51.9 KB View Download

Deleted: [Mac] Supervised user with multiple windows + auth token error.png 67.9 KB

	[Mac] Supervised user with multiple windows + auth token error.png 67.9 KB View Download

Deleted: [Mac] Signed-in user with account consistency mode.png 54.4 KB

	[Mac] Signed-in user with account consistency mode.png 54.4 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b409fbb2cd01a0d05a40dff2daa22685fa14d2f3

commit b409fbb2cd01a0d05a40dff2daa22685fa14d2f3
Author: janeliulwq <janeliulwq@google.com>
Date: Wed Aug 24 22:08:31 2016

[MD User Menu] Un-hardcode profile card's spacing

On MD user menu, vertical spacings in the profile card used to be
hardcoded, hence causing some display problems on certain locales
(see first bug for how Hindi names would get chopped off).

This CL calculates the spacing needed given the height of the profile
name label and/or username label in the profile card, hence fixing
the chopped-off problem - see a new screenshot here: https://screenshot.googleplex.com/FHK5snyG0PH.

BUG= 636321 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2230963004
Cr-Commit-Position: refs/heads/master@{#414167}

[modify] https://crrev.com/b409fbb2cd01a0d05a40dff2daa22685fa14d2f3/chrome/browser/ui/views/profiles/profile_chooser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc337a09e7187b86f0fae15e2ff6f66e28246be8

commit bc337a09e7187b86f0fae15e2ff6f66e28246be8
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue Aug 30 17:34:00 2016

[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG= 640907 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2285413002
Cr-Commit-Position: refs/heads/master@{#415338}

[modify] https://crrev.com/bc337a09e7187b86f0fae15e2ff6f66e28246be8/chrome/browser/ui/views/profiles/profile_chooser_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22d42439d0a2c92efac24822dea1d995ad35985e

commit 22d42439d0a2c92efac24822dea1d995ad35985e
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue Sep 06 15:55:16 2016

[Signin Error Dialog] (1/3) Adds necessary web components

Signin Error Dialog:

Part of the desktop user menu revamp project is to migrate signin error
surfacing from user menu's tutorial card to a tab modal dialog, and thus
completing the flow of signin modal -> sync confirmation modal dialog or
signin error modal dialog.

Particularly, this CL adds the html and js components needed by the
dialog.

Screenshot:
https://drive.google.com/open?id=0B7Fvv7JszRyGamxVRVc5OUVzSVE

Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.9vm5owqqt3w1

BUG=630523
BUG= 615893 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2298503002
Cr-Commit-Position: refs/heads/master@{#416633}

[modify] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/browser_resources.grd
[add] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/resources/signin/signin_error/signin_error.html
[add] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/resources/signin/signin_error/signin_error.js
[add] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/resources/signin/signin_shared_css.html
[rename] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.css
[rename] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.html
[rename] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/resources/signin/sync_confirmation/sync_confirmation.js
[modify] https://crrev.com/22d42439d0a2c92efac24822dea1d995ad35985e/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32af54611ca4a83a599347cf52042c51838c6579

commit 32af54611ca4a83a599347cf52042c51838c6579
Author: anthonyvd <anthonyvd@chromium.org>
Date: Wed Sep 14 21:09:49 2016

[Signin Error Dialog] (2/3) Added handlers and UI constructors

Signin Error Dialog:

Part of the desktop user menu revamp project is to migrate signin error
surfacing from user menu's tutorial card to a tab modal dialog, and thus
completing the flow of signin modal -> sync confirmation modal dialog or
signin error modal dialog.

Particularly, this CL adds the code for appropriately constructing and
handling the dialog.

DO NOT LAND until after the first CL lands
(https://codereview.chromium.org/2274013002/).

Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.9vm5owqqt3w1

BUG=630523
BUG= 615893 

Review-Url: https://codereview.chromium.org/2315393002
Cr-Commit-Position: refs/heads/master@{#418673}

[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/app/generated_resources.grd
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/chromeos/login/test/oobe_base_test.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/profiles/profile_metrics.h
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/signin_view_controller_delegate.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[delete] https://crrev.com/41d79bc2e20416004dd0b8e4f4f4b040cab45a56/chrome/browser/ui/webui/signin/get_auth_frame.h
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/login_ui_service.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/login_ui_service.h
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
[add] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/signin_error_handler.cc
[add] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/signin_error_handler.h
[add] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/signin_error_ui.cc
[add] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/signin_error_ui.h
[rename] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/signin_utils.cc
[add] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/signin_utils.h
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/browser/ui/webui/signin/sync_confirmation_handler.h
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/common/url_constants.cc
[modify] https://crrev.com/32af54611ca4a83a599347cf52042c51838c6579/chrome/common/url_constants.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba01d0f8a7b9fa09457807ee6f83401b5b04e18c

commit ba01d0f8a7b9fa09457807ee6f83401b5b04e18c
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Fri Sep 16 15:19:00 2016

[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG= 640907 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2285413002
Cr-Commit-Position: refs/heads/master@{#415338}
(cherry picked from commit bc337a09e7187b86f0fae15e2ff6f66e28246be8)

Review URL: https://codereview.chromium.org/2345063003 .

Cr-Commit-Position: refs/branch-heads/2840@{#391}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ba01d0f8a7b9fa09457807ee6f83401b5b04e18c/chrome/browser/ui/views/profiles/profile_chooser_view.cc

Tested the issue on Windows 10 and Ubuntu 14.04 using 54.0.2840.34.
Attached the screen cast for the same. Could you please confirm on it.

anthonyvd@ : Could you please confirm the if its fine.

Deleted: Linux_615893_Sept_21.ogv 1.0 MB

	Linux_615893_Sept_21.ogv 1.0 MB View Download

Deleted: Win_615893_Sept_21.mp4 389 KB

	Win_615893_Sept_21.mp4 389 KB View Download

Not holding Beta Release for today, we will take necessary action once the feedback is available for #46.

Behavior in #46 looks correct to me. Note that  Issue 640907  is specifically about the RTL issue - this bug is tracking the overall work on the user menu.

We've repurposed  Issue 640907  to focus on the remaining work left for Mac.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0abc347b7f09546244d619b81a5d0f3c55de3fee

commit 0abc347b7f09546244d619b81a5d0f3c55de3fee
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue Sep 27 15:41:05 2016

[Signin Error Dialog] (3/3) Added the triggering code

Signin Error Dialog:
Part of the desktop user menu revamp project is to migrate signin error
surfacing from user menu's tutorial card to a tab modal dialog, and thus
completing the flow of signin modal -> sync confirmation modal dialog or signin
error modal dialog.

Particularly, this CL adds the code for appropriately triggering the dialog.
DO NOT LAND until after the first two CLs land (
https://codereview.chromium.org/2274013002/,
https://codereview.chromium.org/2275883003/).

Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.9vm5owqqt3w1

BUG=630523
BUG= 615893 

Review-Url: https://codereview.chromium.org/2348423002
Cr-Commit-Position: refs/heads/master@{#421220}

[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/browser.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/browser.h
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/signin_view_controller.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/signin_view_controller.h
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/signin_view_controller_delegate.h
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/webui/signin/inline_login_handler_impl.h
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/webui/signin/login_ui_service.cc
[modify] https://crrev.com/0abc347b7f09546244d619b81a5d0f3c55de3fee/chrome/browser/ui/webui/signin/login_ui_service.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba01d0f8a7b9fa09457807ee6f83401b5b04e18c

commit ba01d0f8a7b9fa09457807ee6f83401b5b04e18c
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Fri Sep 16 15:19:00 2016

[User Menu] Flipped the profile badge to be on the LHS for RTL layouts

Discussed with bettes@ to decide that the profile badge on RTL layouts
should be on the LHS instead.
Also fixed the position of the circular mask for profile icon on RTL
layouts (see first bug) - the circular mask needs to be bumped to the
right on RTL layouts so that it's right-aligned.

See comparative screenshots:
https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing

BUG= 640907 
BUG= 615893 

Review-Url: https://codereview.chromium.org/2285413002
Cr-Commit-Position: refs/heads/master@{#415338}
(cherry picked from commit bc337a09e7187b86f0fae15e2ff6f66e28246be8)

Review URL: https://codereview.chromium.org/2345063003 .

Cr-Commit-Position: refs/branch-heads/2840@{#391}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/ba01d0f8a7b9fa09457807ee6f83401b5b04e18c/chrome/browser/ui/views/profiles/profile_chooser_view.cc

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Marking as Fixed now that this is done.