MacViews: SadTab should use a views::View, not an NSView
Reported by
k...@yandex-team.ru,
May 30 2016
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.63 Safari/537.36 Steps to reproduce the problem: 1. Run MacViews browser, open some tabs. 2. Kill one of the tabs in task manager. What is the expected behavior? 1. SadTabView opens instead tab and looks good. What went wrong? SadTabView positioned incorrect and does not change size according to browser frame. Did this work before? N/A Chrome version: 51.0.2704.63 Channel: dev OS Version: OS X 10.11.3 Flash Version: Shockwave Flash 21.0 r0
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93e85928af1507d34e3ec3735bdb041c438e1d37 commit 93e85928af1507d34e3ec3735bdb041c438e1d37 Author: kirr <kirr@yandex-team.ru> Date: Tue May 31 14:55:09 2016 MacViews: Use native SadTabView in mac_views_browser. Fixed SadTab in MacViews. BUG= 615871 Review-Url: https://codereview.chromium.org/2026583002 Cr-Commit-Position: refs/heads/master@{#396826} [modify] https://crrev.com/93e85928af1507d34e3ec3735bdb041c438e1d37/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/93e85928af1507d34e3ec3735bdb041c438e1d37/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm [modify] https://crrev.com/93e85928af1507d34e3ec3735bdb041c438e1d37/chrome/chrome_browser_ui.gypi
,
Jun 1 2016
,
Dec 12 2016
,
Mar 24 2017
This seems fixed in #2. tapted@, flip the status or is there more work needed?
,
Apr 12 2017
,
Apr 12 2017
#c2 uses sad_tab_view_cocoa.mm but in the long term we _should_ be using sad_tab_view.cc -- i.e. a views::View, not an NSView. But it can wait. Might not even need to block MacViews-Browser, but it will probably block what comes after.
,
Apr 13 2017
,
Apr 13 2017
retitling
,
Aug 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68757f797cf6d990699503d1a47be59b42e109dc commit 68757f797cf6d990699503d1a47be59b42e109dc Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Wed Aug 16 08:04:13 2017 Use sad_tab_view.cc on MacViews Implemented NativeWidgetPrivate::ReparentNativeView() to use sad_tab_view.cc instead of sad_tab_view_cocoa.mm on MacViews. BridgedContentView handles the reparented behavior. Bug: 615871 , 514920 Change-Id: I2d5bc45cc1c63ad7bfcdeee1d5ac7d5ee3c7da2d Reviewed-on: https://chromium-review.googlesource.com/605028 Commit-Queue: Simon Hong <simonhong@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#494722} [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/AUTHORS [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm [add] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_mac.h [add] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views_mac.mm [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/content/browser/web_contents/web_contents_view_mac.mm [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/ui/views/view_unittest.cc [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/ui/views/widget/native_widget_mac.mm [modify] https://crrev.com/68757f797cf6d990699503d1a47be59b42e109dc/ui/views/widget/native_widget_mac_unittest.mm
,
Aug 16 2017
Thanks for the fix! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by meh...@chromium.org
, May 30 2016