Regression : Browser Crash is seen on hitting Enter button while adding source map |
|||||||||||||
Issue descriptionVersion: 53.0.2751.0 OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome -> Go to chrome://settings page (2)Now Press F12 to open Dev tools -> Go to "Sources" tab and click "Ctrl _P" to open files -> select ".js" file (3)Now right click to open context menu -> Select "Add source map" option ->Enter text and hit on "Enter" button from keyboard Expected: Source map should get added Actual: Instead Browser Crash is seen This is Regression Issue broken in M-53 will provide bisect info soon Below are the Crash IDs: Crash ID dc90a25c00000000 (Chrome)
,
May 30 2016
Users experienced this crash on the following builds: Mac Canary 53.0.2751.0 - 0.13 CPM, 1 reports, 1 clients (signature content::SharedResourcesDataSource::GetMimeType) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
May 31 2016
Couldn't be my CL, since these crashes predate it. Here's a Windows one from 52.0.2739.0, for example: a761c36a00000000. (The Windows crashes also have the advantage that the call stack is more legible, and you can open them in a debugger.) @dbeam, can you take a look? The crash is happening on a line you added in r390843. That's also consistent with the first crash of this type apparently being in 52.0.2729.3, which was cut from 392278. (There were some earlier crashes in M50 and before with the same magic signature, but they have a different stack so I'm guessing they're unrelated.)
,
May 31 2016
adding a source map to the settings page is not P1
,
May 31 2016
so, the only issue worth fixing from this report is that we attempt to access std::string().substr(1) which throws (in some configurations, but may not in others). instead: I'll just make the code crash earlier! generally: don't expect to throw random things into chrome:// URLs without issue.
,
May 31 2016
That's not a reason to crash the browser process. Can we detect this case and ignore it instead?
,
May 31 2016
yep, doing that here: https://codereview.chromium.org/2020393002/
,
May 31 2016
Apologies for suggesting the CHECK statement in the first place. (I misunderstood and thought GetMimeType is only invoked on *existing* resources)
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3081ca02d004b57750869a2425fc8bf6c19e1e4 commit e3081ca02d004b57750869a2425fc8bf6c19e1e4 Author: dbeam <dbeam@chromium.org> Date: Wed Jun 01 02:28:05 2016 WebUI: only crash Chrome for invalid chrome:// URLs in debug R=groby@chromium.org BUG= 615847 Review-Url: https://codereview.chromium.org/2020393002 Cr-Commit-Position: refs/heads/master@{#397027} [modify] https://crrev.com/e3081ca02d004b57750869a2425fc8bf6c19e1e4/content/browser/webui/shared_resources_data_source.cc
,
Jun 1 2016
Users experienced this crash on the following builds: Mac Canary 53.0.2753.0 - 0.61 CPM, 2 reports, 2 clients (signature content::SharedResourcesDataSource::GetMimeType) Linux Dev 52.0.2743.19 - 15.21 CPM, 1 reports, 1 clients (signature content::SharedResourcesDataSource::GetMimeType) If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates. - Go/Fracas
,
Jun 1 2016
,
Jun 3 2016
Issue 616689 has been merged into this issue.
,
Aug 9 2016
Issue 635524 has been merged into this issue.
,
Sep 2 2016
Issue 643413 has been merged into this issue. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by brajkumar@chromium.org
, May 30 2016Owner: creis@chromium.org
Status: Assigned (was: Unconfirmed)