[Android N Developer Preview][M50] Model name missed in user agent string
Reported by
seiyon.p...@gmail.com,
May 30 2016
|
||||
Issue descriptionSteps to reproduce the problem: 1. Launch Chrome 2. Open "http://xhaus.com/headers" What is the expected behavior? User agent string include model name. What went wrong? There is no model name in user agent string. Did this work before? Yes User agent string include model name on M OS. Chrome version: 50.0.2661.102 Channel: stable OS Version: 6.0.99 Flash Version: Shockwave Flash 21.0 r0 Chrome, other popular browser apps (firefox, opera) doesn't send model name on N OS. My assumption is that it's not a Chrome problem but platform problem.
,
Jun 9 2016
Ross, is this expected to work? Per issue 392191, it sounds like __system_property_get may not work anymore.
,
Jun 10 2016
Yes, it looks like we are using __system_property_get to get "ro.product.model" for the user agent. I don't think ro.product.model is guaranteed to exist, and the Android team have been working on deprecating __system_property_get (which was never part of the official NDK so shouldn't have been called). We should be using BUILD.model instead, however this means we need to get the info from Java via JNI. I don't have any cycles to work on this right now so removing myself as owner and adding some other folks on cc in case anyone else can pick it up.
,
Jun 10 2016
Looks like jduke had a in-progress patch to do this at https://codereview.chromium.org/1236283002/ which he never managed to land before leaving the team.
,
Jun 17 2016
Gentle reminder
,
Jun 29 2016
just tried this on NRD84 and I see the model number. possibly a change to framework? can you confirm this is sitll an issue?
,
Jul 1 2016
I've checked it's fixed. Thanks.
,
Jul 5 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rsgav...@chromium.org
, Jun 3 2016Status: Assigned (was: Unconfirmed)