Issue metadata
Sign in to add a comment
|
3.4% regression in thread_times.tough_scrolling_cases at 396218:396256 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 30 2016
=== Auto-CCing suspected CL author ccameron@chromium.org === Hi ccameron@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reland of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #1 id:1 of https://codereview.chromium.org/2006153002/ ) Author : ccameron Commit description: Reason for revert: The patch that this depended on, https://codereview.chromium.org/1993333002/, has landed. Original issue's description: > Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #8 id:140001 of https://codereview.chromium.org/1984873002/ ) > > Reason for revert: > Depending on an implementation still in review. Results in flooding of LOG messages. > > https://bugs.chromium.org/p/chromium/issues/detail?id=614155 > https://codereview.chromium.org/1993333002/ > > Original issue's description: > > Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. > > > > The new logic will hold onto GpuMemoryBuffer Resources until they are no longer > > in use by the Window Server. > > > > BUG= 608026 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/87aa976eacd8ed0c530d32a7c85d6ba706dcabf6 > > Cr-Commit-Position: refs/heads/master@{#395150} > > TBR=ccameron@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 608026 > > Committed: https://crrev.com/aa5126ff66379a9060e87b010135f1aee7fc1ab2 > Cr-Commit-Position: refs/heads/master@{#395524} TBR=erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 608026 Review-Url: https://codereview.chromium.org/2015923003 Cr-Commit-Position: refs/heads/master@{#396233} Commit : f8a942fbb35c30edcc88cfe859ceda7b469096af Date : Thu May 26 18:25:28 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396217 9.99306 0.0897028 5 good chromium@396227 10.0397 0.0480613 5 good chromium@396232 10.0471 0.0380158 5 good chromium@396233 10.4369 0.083678 5 bad <-- chromium@396234 10.4579 0.0289953 5 bad chromium@396235 10.4431 0.030611 5 bad chromium@396237 10.452 0.0254066 5 bad chromium@396256 10.391 0.0483165 5 bad Bisect job ran on: mac_10_11_perf_bisect Bug ID: 615836 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.tough_scrolling_cases Test Metric: thread_total_all_cpu_time_per_frame/thread_total_all_cpu_time_per_frame Relative Change: 3.98% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/647 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011238674768596288 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5775141833801728 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 31 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Reland of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #1 id:1 of https://codereview.chromium.org/2006153002/ ) Author : ccameron Commit description: Reason for revert: The patch that this depended on, https://codereview.chromium.org/1993333002/, has landed. Original issue's description: > Revert of Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. (patchset #8 id:140001 of https://codereview.chromium.org/1984873002/ ) > > Reason for revert: > Depending on an implementation still in review. Results in flooding of LOG messages. > > https://bugs.chromium.org/p/chromium/issues/detail?id=614155 > https://codereview.chromium.org/1993333002/ > > Original issue's description: > > Add logic to ResourceProvider to correctly lock GpuMemoryBuffer Resources. > > > > The new logic will hold onto GpuMemoryBuffer Resources until they are no longer > > in use by the Window Server. > > > > BUG= 608026 > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/87aa976eacd8ed0c530d32a7c85d6ba706dcabf6 > > Cr-Commit-Position: refs/heads/master@{#395150} > > TBR=ccameron@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG= 608026 > > Committed: https://crrev.com/aa5126ff66379a9060e87b010135f1aee7fc1ab2 > Cr-Commit-Position: refs/heads/master@{#395524} TBR=erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 608026 Review-Url: https://codereview.chromium.org/2015923003 Cr-Commit-Position: refs/heads/master@{#396233} Commit : f8a942fbb35c30edcc88cfe859ceda7b469096af Date : Thu May 26 18:25:28 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@396217 8.84935 0.0151284 5 good chromium@396227 8.88674 0.022197 5 good chromium@396232 8.8656 0.0204932 5 good chromium@396233 9.185 0.0354941 5 bad <-- chromium@396234 9.18368 0.0174625 5 bad chromium@396235 9.18576 0.0192752 5 bad chromium@396237 9.13447 0.03074 5 bad chromium@396256 9.13371 0.0665496 5 bad Bisect job ran on: mac_10_11_perf_bisect Bug ID: 615836 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.tough_scrolling_cases Test Metric: thread_total_all_cpu_time_per_frame/thread_total_all_cpu_time_per_frame Relative Change: 3.21% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/648 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011238679762618208 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5792992086982656 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Jul 1 2016
Ping ccameron - have you been able to look into this regression?
,
Jul 7 2016
The offending CL has been reverted (and won't be coming back).
,
Aug 22 2016
,
Aug 25 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by primiano@chromium.org
, May 30 2016