It's already on Windows. But I didn't introduce a flag, just via Finch. The config isn
't landed, therefore, we can already decide which % of which channel we are targeting.
Test the feature by launching Chrome with parameters
chrome.exe --force-fieldtrials=PasswordSmartBubble/SomeGroup --force-fieldtrial-params=PasswordSmartBubble.SomeGroup:dismissal_count/2
Test the feature by launching Chrome with parameters
chrome.exe --force-fieldtrials=PasswordSmartBubble/SomeGroup --force-fieldtrial-params=PasswordSmartBubble.SomeGroup:dismissal_count/2
"2" here is the maximum number we show the prompt.
It's ready, I'm eager to fix the bugs they find.
Sorry, I was getting tripped up with "chrome.exe," which obviously doesn't exist on Mac. I figured out it's just /path/to/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary though.
I tried running that ("./Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary --force-fieldtrials=PasswordSmartBubble/SomeGroup --force-fieldtrial-params=PasswordSmartBubble.SomeGroup:dismissal_count/50"), and it's not triggering the promo for me when I save a password. Is there any other setup I need to do for it to work?
Because I copy-pasted the string from another feature :-) This is what you should type
'/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary' --force-fieldtrials=SignInPasswordPromo/SomeGroup --force-fieldtrial-params=SignInPasswordPromo.SomeGroup:dismissal_threshold/2
Are we recording metrics in UMA for this promo? The sign in team has a standard way of recording metrics. If we want to match the way we're recording metrics for the rest of our sign in promos (which I'd prefer), we'd have:
- Signin_Impression_FromPasswordBubble. A user action that's recorded when the promo is shown
- Signin_Signin_FromPasswordBubble. A user action that's recorded when the user clicks "Sign in" in the bubble
- Signin.SigninStartedAccessPoint.[Password bubble]. A new bucket in the Signin.SigninStartedAccessPoint histogram that gets recorded when the sign in flow is initiated from the password bubble
- Signin.SigninCompletedAccessPoint.[Password bubble]. A new bucket in the Signin.SigninCompletedAccessPoint histogram that gets recorded when the sign in flow that's initiated from the password bubble gets completed.
Then we can calculate:
- CTR: Signin_Signin_FromPasswordBubble/Signin_Signin_FromPasswordBubble
- Completion of the sign in flow: Signin.SigninCompletedAccessPoint.[Password bubble]/Signin.SigninStartedAccessPoint.[Password bubble]
- Overall completion rate of the funnel: (CTR) * (Completion of the sign in flow)
You can look at what we're doing with the BookmarkBubble as an example. Ganggui (cc'ed) implemented all our metrics tracking. He and I can answer any questions you have!
Does that make sense to you?
From the UI review thread: "The padding between the left edge of the bubble and where the text starts seems to vary in Alex's gif. Can we fix that?"
Looks like the left-edge-padding is different between the initial password save bubble and the sign in promo bubble.
Re 25: a new bucket in Signin.Signin* already exists. Interaction with the promo are already recorded in the following way:
"PasswordManager.SignInPromo" histogram records what user did with the promo (Sign in, No thanks, dismissed) every time it's shown. It shows CTR.
When the user dismisses the promo permanently (Sign in or No thanks) "PasswordManager.SignInPromoCountTilClick" records the number of times it was shown to the user.
Re #30: terrific, thanks Vasilii! That all sounds great.
Could we possibly add two new user actions (Signin_Impression_FromPasswordBubble and Signin_Signin_FromPasswordBubble) that get recorded when the promo is shown and when "Sign in" is clicked, respectively?
I know it's duplicating data in the PasswordManager.SignInPromo histogram, but then we'll be able to use the User Action Sequencer to look at the funnel for signing in across all our user actions/access points :)
Tried with 'chrome.exe --force-fieldtrials=SignInPasswordPromo/SomeGroup --force-fieldtrial-params=SignInPasswordPromo.SomeGroup:dismissal_threshold/2' on Win7, Mac OS X & Ubuntu 14.04 using Dev # 53.0.2785.8 - seeing sign in promo with 'x' button.
attached screenshot for reference, adding TE-Verified labels.
Comment 1 by ew...@chromium.org
, May 31 2016