New issue
Advanced search Search tips

Issue 615814 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ASSERTION FAILED: outer.isRounded()

Project Member Reported by ClusterFuzz, May 30 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5646364042330112

Fuzzer: inferno_twister
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  ASSERTION FAILED: outer.isRounded()
  blink::drawBleedAdjustedDRRect
  blink::BoxBorderPainter::drawDoubleBorder
  

Minimized Testcase (0.27 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97yiY6LoSDmtuNuFh4wHrqL0wCmaT8Mdryfpf-sngGfEPexOeq4Hqwt8yAVMArWsgVHQTsoL0v5VNOTUssDPO6MVt7a-nOgOPcKqdwGj53HrTWnbn3ilNYJPNrFHgA1gifEXjo454PjKqCz8egUuH4Xirq9dw

Filer: ajha

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by ajha@chromium.org, May 30 2016

Components: Tools>Test>FindIt>WrongResult Blink>Paint
Labels: -Type-Bug Te-Logged Type-Bug-Regression
Owner: fmalita@chromium.org
Status: Assigned (was: Available)
Suspected CLs	Regression information is not available. The result is the blame information.

Author: fmalita@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/98a2dabd74c38be5a6e9d8c5d21d0a43764c370d
Time: Tue Jun 02 03:28:41 2015
The CL last changed line 281 of file BoxBorderPainter.cpp, which is stack frame 0.

Author: fmalita@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/a335a852f6cab6069b893e654b5b7c9b54123445
Time: Tue Jun 02 15:41:49 2015
The CL last changed line 468 of file BoxBorderPainter.cpp, which is stack frame 1.

Author: fmalita@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/a335a852f6cab6069b893e654b5b7c9b54123445
Time: Tue Jun 02 15:41:49 2015
The CL last changed line 498 of file BoxBorderPainter.cpp, which is stack frame 2.

Author: fmalita@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/a335a852f6cab6069b893e654b5b7c9b54123445
Time: Tue Jun 02 15:41:49 2015
The CL last changed line 617 of file BoxBorderPainter.cpp, which is stack frame 3.

Author: fmalita@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/a335a852f6cab6069b893e654b5b7c9b54123445
Time: Tue Jun 02 15:41:49 2015
The CL last changed line 698 of file BoxPainter.cpp, which is stack frame 4.

Author: fmalita@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/64f7aaa4bbeefa22102d7f69739d738a29e67c16
Time: Thu Apr 16 19:48:07 2015
The CL last changed line 119 of file BoxPainter.cpp, which is stack frame 5.

Author: chrishtr@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/7a25d907698e89274bebe3cabf8865bff2b63384
Time: Wed Sep 10 16:29:19 2014
The CL last changed line 51 of file BoxPainter.cpp, which is stack frame 6.

Suspected Project: chromium
Suspected Component: Blink>Paint


None of the Find it result looks related.

fmalita@: Could you please confirm if this could be related to recent changes here: https://codereview.chromium.org/1949253004

Please help in finding an appropriate owner if the change is not related.

Thank you!
Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by ClusterFuzz, Dec 22 2016

Status: WontFix (was: Assigned)
ClusterFuzz testcase 5646364042330112 is flaky and no longer reproduces, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: chrishtr@chromium.org
Labels: ClusterFuzz-Wrong
Status: Assigned (was: WontFix)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8

commit f55c47a99fd4f05e07f5ecc1bd29c359082f43d8
Author: fmalita <fmalita@chromium.org>
Date: Thu Dec 29 20:17:35 2016

Remove BoxBorderPainter::drawBleedAdjustedDRRect() assert

While we only ever use BackgroundBleedClipLayer when hasBorderRadius()
is true, certain degenerate radius values can cause the computed radii
to be zero.

In that case the assert no longer holds.  The simplest thing to do is
drop the assert: SkPath::addRRect() checks for the simple rect case and
behaves optimally anyway.

BUG= 615814 
R=chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2606913002
Cr-Commit-Position: refs/heads/master@{#440981}

[add] https://crrev.com/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8/third_party/WebKit/LayoutTests/paint/roundedrects/degenerate-radius-assert-expected.txt
[add] https://crrev.com/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8/third_party/WebKit/LayoutTests/paint/roundedrects/degenerate-radius-assert.html
[modify] https://crrev.com/f55c47a99fd4f05e07f5ecc1bd29c359082f43d8/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

Status: Fixed (was: Assigned)
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment