New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615808 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.2%-11.4% regression in speedometer at 393839:396653

Project Member Reported by epertoso@chromium.org, May 30 2016

Issue description

Speedometer alerts seem to get triggered easily, looking at the graph it seems that the performance measurement are really flaky, and we get a lot of alerts on spikes.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 30 2016

Cc: nek...@chromium.org
Owner: nek...@chromium.org

=== Auto-CCing suspected CL author nektar@chromium.org ===

Hi nektar@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Uses the activedescendant_changed event received from Blink to fire the right focus event on the browser side.
Author  : nektar
Commit description:
  
1. Changed all <select> based widgets (list box role and menu list popup role) to fire activedescendant_changed events when the current selection changes. This behavior is the same as with ARIA combo boxes and other ARIA-based widgets that can have an active descendant. This means that we now have a uniform way of notifying the browser when the active child of a widget has changed.
2. Modified platform-specific code to fire the focus events on the active descendant when it changes, instead of relying on Blink.
3. Fires a focus event on the whole list or combo box when it collapses to make Windows screen readers enable their virtual cursor again.
BUG= 593646 
R=dmazzoni@chromium.org
TESTED=Jaws NVDA and VoiceOver, browser tests

Review-Url: https://codereview.chromium.org/1899823002
Cr-Commit-Position: refs/heads/master@{#396653}
Commit  : 2c4ec4bed7e28e4f45efe742833dd3a154ac266b
Date    : Sun May 29 01:28:05 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@396652  309.225  3.50332  8  good
chromium@396653  315.445  4.58123  8  bad    <--

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 615808

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: BackboneJS-TodoMVC/BackboneJS-TodoMVC
Relative Change: 1.30%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2129
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011246319814290864


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5861214689689600

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, May 30 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@395746  597.789  11.0709  18  good
chromium@395778  598.585  7.94334  18  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 615808

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: jQuery-TodoMVC/jQuery-TodoMVC
Relative Change: 1.94%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/931
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011246276395269520


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5827692469944320

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 30 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@395403  1394.22  33.8378  18  good
chromium@395421  1376.95  32.9447  18  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 615808

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: VanillaJS-TodoMVC/VanillaJS-TodoMVC
Relative Change: 1.50%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2204
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011246231912284064


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5785442239119360

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -performance-sheriff Performance-Sheriff
Status: WontFix (was: Assigned)
As noted by epertoso, these alerts are really noisy, and bisect failed to clearly reproduce. Closing.

Sign in to add a comment