New issue
Advanced search Search tips

Issue 615799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Upstream physical_web code

Project Member Reported by sdefresne@chromium.org, May 30 2016

Issue description

This is the sole client of devices/bluetooth/uribeacon, so in order to prevent upstream developer to remove this code (as unused), upstream the code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88abe3610f66d114d2e2e4e637433c9eae677a6b

commit 88abe3610f66d114d2e2e4e637433c9eae677a6b
Author: sdefresne <sdefresne@chromium.org>
Date: Wed Jun 01 10:40:11 2016

[iOS] Upstream physical web classes.

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG= 615799 

Review-Url: https://codereview.chromium.org/2023833002
Cr-Commit-Position: refs/heads/master@{#397098}

[modify] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/BUILD.gn
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/BUILD.gn
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/BUILD.gn
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/DEPS
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/OWNERS
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web.gyp
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_device.h
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_device.mm
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_request.h
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_request.mm
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_scanner.h
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_scanner.mm
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_types.h
[add] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/chrome/common/physical_web/physical_web_types.mm
[modify] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/ios/ios.gyp
[modify] https://crrev.com/88abe3610f66d114d2e2e4e637433c9eae677a6b/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/30b4fffde13505e596a2be1f616123190b024f15

commit 30b4fffde13505e596a2be1f616123190b024f15
Author: sdefresne <sdefresne@google.com>
Date: Thu Jun 02 13:29:42 2016

Status: Fixed (was: Started)

Sign in to add a comment