HtmlAudioElementCapturerSource::OnAudioBus receives delay in frames but interprets it as ms. |
|||||||
Issue description
,
May 30 2016
,
May 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09f80bc860fedce41702537cdd742ae03370bfdf commit 09f80bc860fedce41702537cdd742ae03370bfdf Author: olka <olka@chromium.org> Date: Mon May 30 17:40:57 2016 Fixing HtmlAudioElementCapturerSource::OnAudioBus() to accept delay frames intead of milliseconds. (frames are passed here https://cs-staging.chromium.org/chromium/src/media/blink/webaudiosourceprovider_impl.cc?sq=package:chromium&dr=C&rcl=1464592669&l=276) BUG= 615783 Review-Url: https://codereview.chromium.org/2025643002 Cr-Commit-Position: refs/heads/master@{#396744} [modify] https://crrev.com/09f80bc860fedce41702537cdd742ae03370bfdf/content/renderer/media/html_audio_element_capturer_source.cc [modify] https://crrev.com/09f80bc860fedce41702537cdd742ae03370bfdf/content/renderer/media/html_audio_element_capturer_source.h
,
May 31 2016
,
Jun 2 2016
I'm not sure if the original code ended up in M52 (looks like it was re-laned later). mcasas@, could you take care of the merge to M52 if it's the case?
,
Jun 2 2016
Original CL landed as https://crrev.com/2010173002/ --> 396564 and 52 Dev is in 394939, so we should merge it there. Will do the merge.
,
Jun 2 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 2 2016
Sorry, it must (have) be(en) too early and couldn't read the numbers I wrote in #6 :P It landed as 396564, and Dev is 394939, so it's not necessary (nor possible) to merge back to M52 (and I just found out while trying to merge back and finding no html_audio... files). Apologies tinazh@ |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by olka@chromium.org
, May 30 2016