New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615760 link

Starred by 2 users
Status: Verified
Owner:
pkasting@chromium.org
Closed: Jun 2016
Cc:
█ mgiuca@chromium.org
nyerramilli@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 610039



Sign in to add a comment

Consider hiding backspace shortcut bubble on some or all navigations

Reported by rk...@etouch.net, May 30 2016 
Chrome Version: 53.0.2751.0 Revision 25dc7aadaf1e9e972b9e7ae1ca706d61b247c577-refs/heads/master@{#396593}
OS: Windows(7,8,10), Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and navigate to https://plus.google.com/collections/featured
(2) Press 'Backspace' and then press Alt+Left arrow, observe.

Unnecessary "Press Alt+Left Arrow to go back" infobar is seen on NTP.

"Press Alt+Left Arrow to go back" infobar should not seen on NTP.

This is a regression issue, broken in 'M-53', will soon update the other info.

Good Build: 53.0.2749.0
Bad Build: 53.0.2750.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/0063cf80ae18f025807016c41f17462d51bee872..5783d8c7eb60443d5d31d7e9bbb095d897caf3f0?pretty=fuller&n=50

Suspecting: r396138
Actual_Result.mp4
717 KB Download
Screenshot.png
25.9 KB View Download

Comment 1 by pkasting@chromium.org, May 30 2016

Blocking: 610039
Cc: -pkasting@chromium.org mgiuca@chromium.org
Components: -IO>Keyboard -UI>Browser>Infobars UI>Input>KeyboardShortcuts
Labels: -Pri-1 -hasbisect -M-53 -Type-Bug-Regression M-52 OS-Chrome Pri-3 Type-Bug
Owner: pkasting@chromium.org
Summary: Consider hiding backspace shortcut bubble on some or all navigations (was: Regression: Unnecessary "Press Alt+Left Arrow to go back" infobar is seen on NTP.)
If there is any bug here, it's that we don't hide the bubble if you navigate (or maybe if you navigate via alt-left).  But the bubble in general is not wrong, and I'm not even sure that we should be hiding it on one of the above navigations.

Assigning to myself to think about this, since I'll be mucking with the triggering logic anyway.
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36aa72944195f579454c1d3abea5045219fd685a

commit 36aa72944195f579454c1d3abea5045219fd685a
Author: pkasting <pkasting@chromium.org>
Date: Fri Jun 10 05:49:08 2016

Add heuristics to limit showing of new backspace UI bubble.

This restricts the bubble to showing 5 times, and only showing when users
trigger backspace twice within three seconds (which likely indicates "hey, why
isn't the browser going back").

The bubble is also immediately hidden (by fading out) if the user successfully
navigates back or forward (by any means) while it's showing.

BUG= 610039 , 615760 
TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds.  After the UI is shown 5 times, it should not appear again.
TBR=phajdan.jr

Review-Url: https://codereview.chromium.org/2041293002
Cr-Commit-Position: refs/heads/master@{#399114}

[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/new_back_shortcut_bubble.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/new_back_shortcut_bubble.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/common/pref_names.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/common/pref_names.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/test/base/test_browser_window.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2016

Labels: merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6895d9eea0c14482c02bb6b27e756f3fd2abdff2

commit 6895d9eea0c14482c02bb6b27e756f3fd2abdff2
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Jun 14 22:30:38 2016

Add heuristics to limit showing of new backspace UI bubble.

This restricts the bubble to showing 5 times, and only showing when users
trigger backspace twice within three seconds (which likely indicates "hey, why
isn't the browser going back").

The bubble is also immediately hidden (by fading out) if the user successfully
navigates back or forward (by any means) while it's showing.

BUG= 610039 , 615760 
TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds.  After the UI is shown 5 times, it should not appear again.
TBR=phajdan.jr

Review-Url: https://codereview.chromium.org/2041293002
Cr-Commit-Position: refs/heads/master@{#399114}
(cherry picked from commit 36aa72944195f579454c1d3abea5045219fd685a)

Review URL: https://codereview.chromium.org/2065283002 .

Cr-Commit-Position: refs/branch-heads/2743@{#358}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/new_back_shortcut_bubble.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/new_back_shortcut_bubble.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/common/pref_names.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/common/pref_names.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/test/base/test_browser_window.h

Comment 5 by pkasting@chromium.org, Jun 14 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36aa72944195f579454c1d3abea5045219fd685a

commit 36aa72944195f579454c1d3abea5045219fd685a
Author: pkasting <pkasting@chromium.org>
Date: Fri Jun 10 05:49:08 2016

Add heuristics to limit showing of new backspace UI bubble.

This restricts the bubble to showing 5 times, and only showing when users
trigger backspace twice within three seconds (which likely indicates "hey, why
isn't the browser going back").

The bubble is also immediately hidden (by fading out) if the user successfully
navigates back or forward (by any means) while it's showing.

BUG= 610039 , 615760 
TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds.  After the UI is shown 5 times, it should not appear again.
TBR=phajdan.jr

Review-Url: https://codereview.chromium.org/2041293002
Cr-Commit-Position: refs/heads/master@{#399114}

[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/new_back_shortcut_bubble.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/browser/ui/views/new_back_shortcut_bubble.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/common/pref_names.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/common/pref_names.h
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/36aa72944195f579454c1d3abea5045219fd685a/chrome/test/base/test_browser_window.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6895d9eea0c14482c02bb6b27e756f3fd2abdff2

commit 6895d9eea0c14482c02bb6b27e756f3fd2abdff2
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Jun 14 22:30:38 2016

Add heuristics to limit showing of new backspace UI bubble.

This restricts the bubble to showing 5 times, and only showing when users
trigger backspace twice within three seconds (which likely indicates "hey, why
isn't the browser going back").

The bubble is also immediately hidden (by fading out) if the user successfully
navigates back or forward (by any means) while it's showing.

BUG= 610039 , 615760 
TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds.  After the UI is shown 5 times, it should not appear again.
TBR=phajdan.jr

Review-Url: https://codereview.chromium.org/2041293002
Cr-Commit-Position: refs/heads/master@{#399114}
(cherry picked from commit 36aa72944195f579454c1d3abea5045219fd685a)

Review URL: https://codereview.chromium.org/2065283002 .

Cr-Commit-Position: refs/branch-heads/2743@{#358}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/new_back_shortcut_bubble.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/browser/ui/views/new_back_shortcut_bubble.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/common/pref_names.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/common/pref_names.h
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/test/base/test_browser_window.cc
[modify] https://crrev.com/6895d9eea0c14482c02bb6b27e756f3fd2abdff2/chrome/test/base/test_browser_window.h

Comment 8 by ashej...@chromium.org, Jun 15 2016

Labels: TE-Verified-M52 TE-Verified-52.0.2743.41
Tested the above issue on Windows, Mac 10.11.4 & Ubuntu 14.04 with chrome version '52.0.2743.41' and the alert fades out when user successfully navigates back and forward. Hence marking the same as TE-Verified-52.0.2743.41.

Attach is the screen-cast for the same.

Thank you!
615760- 16 June.ogv
1.7 MB View Download

Comment 9 by rookrishna@chromium.org, Aug 12 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment