Deprecate chrome://flash page |
||||||
Issue descriptionThe chrome://flash page gets very little use and has information that can be derived from other sources.
,
Apr 19 2018
Hm, we removed the chrome://plugins page not too long ago, with the argument that Flash is the only interesting plugin, and Flash information is available at chrome://flash :) I suspect this bug predates that and now chrome://flash is in fact the only source for that information.
,
Apr 19 2018
My sense is that it can be safely removed. The information on chrome://flash is largely an aggregation of data that can be found elsewhere (e.g., chrome://version - flash path, chrome://gpu - GPU info, chrome://crashes). We also don't reference the url (chrome://flash) in any specific documentation. As additional background on the removal of chrome://plugins. It's correct that it was done because Flash was the last plugin but also that we wanted a single point of control that was in Chrome Settings.
,
Apr 19 2018
We must not lose the Flash version and the path that Flash was actually loaded from. It appears this is currently available on chrome://version. All the other information on chrome://flash indeed seems generic (crashes are general, gpu information etc.)
,
Aug 9
,
Nov 23
,
Dec 10
,
Dec 11
I asked on a documentation thread whether there is any need for heads-up in the blog posts before we go ahead with this bug.
,
Dec 11
A blog post entry for this shouldn't be necessary.
,
Dec 12
I am on this one already.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80 commit 05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80 Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Wed Dec 12 21:25:30 2018 Remove chrome://flash page. All information on this page is duplicate of information from other sources. The Flash plugin version and path can be found on chrome://version. GPU information is present of chrome://gpu and crashes on chrome://crashes. BUG= 615739 Change-Id: Ic0dce75db63099715145a63cac82316494a87b12 Reviewed-on: https://chromium-review.googlesource.com/c/1373841 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616047} [modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/app/generated_resources.grd [modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [delete] https://crrev.com/07da7abb832823271c33c953c85530e27dd2c6d0/chrome/browser/ui/webui/flash_ui.cc [delete] https://crrev.com/07da7abb832823271c33c953c85530e27dd2c6d0/chrome/browser/ui/webui/flash_ui.h [modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/common/webui_url_constants.cc [modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/common/webui_url_constants.h
,
Dec 12
Done. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ellyjo...@chromium.org
, Apr 19 2018Status: Assigned (was: Untriaged)