New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615739 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Deprecate chrome://flash page

Project Member Reported by lafo...@chromium.org, May 30 2016

Issue description

The chrome://flash page gets very little use and has information that can be derived from other sources.

 
Owner: bauerb@chromium.org
Status: Assigned (was: Untriaged)
Mac triage: over to one of the webui owners for triage.

Comment 2 by bauerb@chromium.org, Apr 19 2018

Owner: pastarmovj@chromium.org
Hm, we removed the chrome://plugins page not too long ago, with the argument that Flash is the only interesting plugin, and Flash information is available at chrome://flash :) I suspect this bug predates that and now chrome://flash is in fact the only source for that information.

Comment 3 by laforge@google.com, Apr 19 2018

My sense is that it can be safely removed.

The information on chrome://flash is largely an aggregation of data that can be found elsewhere (e.g., chrome://version - flash path, chrome://gpu - GPU info, chrome://crashes).  We also don't reference the url (chrome://flash) in any specific documentation.

As additional background on the removal of chrome://plugins.  It's correct that it was done because Flash was the last plugin but also that we wanted a single point of control that was in Chrome Settings.  

Comment 4 by ihf@chromium.org, Apr 19 2018

We must not lose the Flash version and the path that Flash was actually loaded from. It appears this is currently available on chrome://version.

All the other information on chrome://flash indeed seems generic (crashes are general, gpu information etc.)
Cc: -rsch...@chromium.org
Labels: Hotlist-Enterprise-Fixit
Cc: nicolaso@chromium.org
I asked on a documentation thread whether there is any need for heads-up in the blog posts before we go ahead with this bug. 
A blog post entry for this shouldn't be necessary.
I am on this one already.

Comment 11 Deleted

Comment 12 Deleted

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80

commit 05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80
Author: Julian Pastarmov <pastarmovj@chromium.org>
Date: Wed Dec 12 21:25:30 2018

Remove chrome://flash page.

All information on this page is duplicate of information from other
sources.
The Flash plugin version and path can be found on chrome://version.
GPU information is present of chrome://gpu and crashes on chrome://crashes.

BUG= 615739 

Change-Id: Ic0dce75db63099715145a63cac82316494a87b12
Reviewed-on: https://chromium-review.googlesource.com/c/1373841
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616047}
[modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/app/generated_resources.grd
[modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[delete] https://crrev.com/07da7abb832823271c33c953c85530e27dd2c6d0/chrome/browser/ui/webui/flash_ui.cc
[delete] https://crrev.com/07da7abb832823271c33c953c85530e27dd2c6d0/chrome/browser/ui/webui/flash_ui.h
[modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/05fe2faf641bb9c29fe9c454c8e3e6f0f7a65e80/chrome/common/webui_url_constants.h

Labels: M-73
Status: Fixed (was: Assigned)
Done.

Sign in to add a comment