New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615720 link

Starred by 1 user
Status: Fixed
Owner:
█ scheib@chromium.org
Not currently working on Chromium
Closed: Aug 2016
Cc:
█ mcchou@chromium.org
█ ejcaruso@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 586438



Sign in to add a comment

bluetooth: Expose the raw device name as well as the name for display.

Project Member Reported by scheib@chromium.org, May 29 2016 
Previously BluetoothDevice::GetName was the only public method to access a devices name, however it creates a synthetic name when the device name is empty.

GetName should be replaced by GetNameForDisplay.

private GetDeviceName should be replaced by a public GetName that can return a non-existing name at all (not even empty string).

Comment 1 by esdrasal...@gmail.com, May 29 2016 

i need the file of arc welder
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5ccec5c2d64133be10106ade6b1fc97a3183c6b

commit e5ccec5c2d64133be10106ade6b1fc97a3183c6b
Author: scheib <scheib@chromium.org>
Date: Thu Jun 02 20:42:49 2016

bluetooth: Rename device's GetName to GetNameForDisplay

This change prepares for Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

It is desired for GetName to return the actual device name. To prepare
for that this change renames the previous GetName behavior to
GetNameForDisplay.

http://crrev.com/2017393002 GetName -> GetNameForDisplay <<< This change.
http://crrev.com/2009753002 New GetName
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG= 615720 

TBR=jam
For method rename refactor crossing many disparate owners.

Review-Url: https://codereview.chromium.org/2017393002
Cr-Commit-Position: refs/heads/master@{#397500}

[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/chrome/browser/chromeos/login/screens/hid_detection_screen.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/components/pairing/bluetooth_controller_pairing_controller.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder_unittest.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/device/bluetooth/test/mock_bluetooth_device.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/device/bluetooth/test/mock_bluetooth_device.h
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/extensions/browser/api/bluetooth/bluetooth_api_utils.cc
[modify] https://crrev.com/e5ccec5c2d64133be10106ade6b1fc97a3183c6b/extensions/browser/api/bluetooth/bluetooth_apitest.cc

Comment 3 by mcchou@chromium.org, Jun 6 2016

Cc: mcchou@chromium.org ejcaruso@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9ce700bede9a707b4b7991ba72417c48cebce7

commit dd9ce700bede9a707b4b7991ba72417c48cebce7
Author: scheib <scheib@chromium.org>
Date: Thu Jul 21 07:06:06 2016

bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG= 615720 

Review-Url: https://codereview.chromium.org/2009753002
Cr-Commit-Position: refs/heads/master@{#406790}

[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_adapter_win_unittest.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_classic_device_mac.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_classic_device_mac.mm
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device_android.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device_android.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device_win.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device_win.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_device_win_unittest.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_low_energy_device_mac.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_low_energy_device_mac.mm
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_low_energy_win.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_low_energy_win.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluetooth_task_manager_win.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluez/bluetooth_device_bluez.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/bluez/bluetooth_device_bluez.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/test/bluetooth_test_mac.mm
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/test/mock_bluetooth_device.cc
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/device/bluetooth/test/mock_bluetooth_device.h
[modify] https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7/extensions/browser/api/bluetooth/bluetooth_apitest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf017029c4d8f7724940b07bbbcf39b54ddec7b

commit 5cf017029c4d8f7724940b07bbbcf39b54ddec7b
Author: scheib <scheib@chromium.org>
Date: Tue Aug 02 22:40:11 2016

bluetooth: Update ARC Bridge to use BluetoothDevice::GetName

Previously GetNameForDisplay was used, which exposes Chrome specific
fallbacks for non-existant or empty names.

GetName returns a value or empty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated <<< This change.

BUG= 615720 

Review-Url: https://codereview.chromium.org/2020923002
Cr-Commit-Position: refs/heads/master@{#409357}

[modify] https://crrev.com/5cf017029c4d8f7724940b07bbbcf39b54ddec7b/components/arc/bluetooth/arc_bluetooth_bridge.cc

Comment 6 by scheib@chromium.org, Aug 2 2016

Status: Fixed (was: Started)
►

Sign in to add a comment