New issue
Advanced search Search tips

Issue 615637 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Disable HTTP/2 Alternative Service if alternative hostname is different from that of origin

Project Member Reported by b...@chromium.org, May 28 2016

Issue description

This would be a temporary restriction until issue 615413 is fixed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bef8da2318c3684b94c866bf194e8c427195b6a

commit 8bef8da2318c3684b94c866bf194e8c427195b6a
Author: bnc <bnc@chromium.org>
Date: Mon May 30 01:28:25 2016

Disable HTTP/2 Alternative Service for different host.

Disable HTTP/2 Alternative Service if origin and alternative have different
hostnames.  This is a temporary workaround until https://crbug.com/615413 is
fixed.

BUG= 615637 

Review-Url: https://codereview.chromium.org/2017323002
Cr-Commit-Position: refs/heads/master@{#396665}

[modify] https://crrev.com/8bef8da2318c3684b94c866bf194e8c427195b6a/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/8bef8da2318c3684b94c866bf194e8c427195b6a/net/http/http_stream_factory_impl.cc

Comment 2 by b...@chromium.org, Jun 1 2016

Labels: Merge-Request-52
Requesting merge into 2743.  Change was picked up by Canary 53.0.2753.0, no relevant crashes.  Thank you.

Comment 3 by tin...@google.com, Jun 1 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53e84392cad0abfafa9a8e5923330f9d679a8e20

commit 53e84392cad0abfafa9a8e5923330f9d679a8e20
Author: Bence Béky <bnc@chromium.org>
Date: Wed Jun 01 11:29:14 2016

Disable HTTP/2 Alternative Service for different host.

Disable HTTP/2 Alternative Service if origin and alternative have different
hostnames.  This is a temporary workaround until https://crbug.com/615413 is
fixed.

BUG= 615637 

Review-Url: https://codereview.chromium.org/2017323002
Cr-Commit-Position: refs/heads/master@{#396665}
(cherry picked from commit 8bef8da2318c3684b94c866bf194e8c427195b6a)

Review URL: https://codereview.chromium.org/2026293002 .

Cr-Commit-Position: refs/branch-heads/2743@{#162}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/53e84392cad0abfafa9a8e5923330f9d679a8e20/net/http/http_network_transaction_unittest.cc
[modify] https://crrev.com/53e84392cad0abfafa9a8e5923330f9d679a8e20/net/http/http_stream_factory_impl.cc

Comment 5 by b...@chromium.org, Jun 1 2016

Status: Fixed (was: Started)

Sign in to add a comment