New issue
Advanced search Search tips

Issue 615630 link

Starred by 2 users
Status: Fixed
Owner:
r...@igalia.com
Closed: May 2016
Cc:
jfernan...@igalia.com
r...@igalia.com
svil...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 273898



Sign in to add a comment

[css-grid] Positioned items can be placed on the implicit grid

Project Member Reported by r...@igalia.com, May 28 2016 
It should be possible to place positioned items on the implicit grid.
Right now the code doesn't allow it, but the spec doesn't say anything.

More info: https://blogs.igalia.com/mrego/2016/05/27/css-grid-layout-and-positioned-items/#positioned-items-and-implicit-grid
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5583f72362240b14f4f29facb90a24cd6a1ef516

commit 5583f72362240b14f4f29facb90a24cd6a1ef516
Author: rego <rego@igalia.com>
Date: Mon May 30 11:29:44 2016

[css-grid] Positioned items can be placed on the implicit grid

The old code wrongly assumed that positioned items couldn't be placed
on the implicit grid.
However, the spec doesn't mention anything about this.

The patch fixes this issue, so now positioned items can be actually
placed on the implicit tracks.
Updated the test to follow the expected behavior.

BUG= 615630 
TEST=fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html

Review-Url: https://codereview.chromium.org/2021683002
Cr-Commit-Position: refs/heads/master@{#396711}

[modify] https://crrev.com/5583f72362240b14f4f29facb90a24cd6a1ef516/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html
[modify] https://crrev.com/5583f72362240b14f4f29facb90a24cd6a1ef516/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Comment 2 by r...@igalia.com, May 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment