New issue
Advanced search Search tips

Issue 615584 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Linux client crashes on connecting

Project Member Reported by xyzzyz@chromium.org, May 28 2016

Issue description

xyzzyz@xyzzyz:~/chromium/src$ ./out/Default/blimp_shell   --user-data-dir=/tmp/blimpclient   --enable-logging=stderr --engine-ip=127.0.0.1 --engine-port=25467 --engine-transport=tcp --blimp-client-token-path=/tmp/blimpengine-token                                                                                                                                                        
[INFO:blimp_startup.cc(66)] Chromium logging enabled: level = 0, default verbosity = 0                                                                                                         
[VERBOSE1:blimp_client_session.cc(202)] Trying to get assignment.                                                                                                                              
[VERBOSE1:blimp_client_session.cc(217)] Assignment succeeded                                                                                                                                   
[VERBOSE1:blimp_client_session.cc(144)] Connecting to 127.0.0.1:25467 (TCP)                                                                                                                    
[VERBOSE1:blimp_connection.cc(67)] Sending <BlimpMessage type=PROTOCOL_CONTROL subtype=START_CONNECTION client_token="MyVoiceIsMyPassport" protocol_version=0 byte_size=29>                    
[VERBOSE1:blimp_client_session.cc(157)] Connection established.                                                                                                                                
[VERBOSE1:blimp_message_pump.cc(28)] SetMessageProcessor, processor=0x355b97461100                                                                                                             
[VERBOSE1:blimp_connection.cc(67)] Sending <BlimpMessage type=TAB_CONTROL subtype=SIZE size=0x0:1.00 byte_size=17>                                                                             
[VERBOSE1:blimp_connection.cc(67)] Sending <BlimpMessage type=TAB_CONTROL subtype=SIZE size=800x600:1.00 byte_size=19>                                                                         
[VERBOSE1:blimp_connection.cc(67)] Sending <BlimpMessage type=TAB_CONTROL subtype=CREATE_TAB byte_size=8>                                                                                      
[VERBOSE1:blimp_connection.cc(67)] Sending <BlimpMessage type=NAVIGATION subtype=LOAD_URL url="https://www.google.com/" target_tab_id=0 byte_size=37>                                          
[VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=RENDER_WIDGET subtype=CREATED render_widget_id=1 target_tab_id=0 byte_size=11>                                                
[VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=RENDER_WIDGET subtype=INITIALIZE render_widget_id=1 target_tab_id=0 byte_size=11>                                             
[VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=NAVIGATION subtype=NAVIGATION_STATE_CHANGED loading=true target_tab_id=0 byte_size=14>                                        
[VERBOSE1:blimp_message_pump.cc(59)] Received <BlimpMessage type=46 target_tab_id=0 byte_size=11>                                                                                              
[FATAL:ime_feature.cc(41)] Check failed: delegate_.                                                                                                                                            
#0 0x000007abdc3e base::debug::StackTrace::StackTrace()                                                                                                                                        
#1 0x000007afb42f logging::LogMessage::~LogMessage()                                                                                                                                           
#2 0x0000019fe74e blimp::client::ImeFeature::ProcessMessage()                                                                                                                                  
#3 0x00000058313d blimp::(anonymous namespace)::DispatchProcessMessage()                                                                                                                       
#4 0x000000584f27 _ZN4base8internal15RunnableAdapterIPFvNS_7WeakPtrIN5blimp22BlimpMessageThreadPipeEEESt10unique_ptrINS3_12BlimpMessageESt14default_deleteIS7_EERKNS_8CallbackIFviELNS0_8CopyModeE1EEEEE3RunIJRKS5_SA_SG_EEEvDpOT_                                                                                                                                                            
#5 0x000000584e1f _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIPFvNS_7WeakPtrIN5blimp22BlimpMessageThreadPipeEEESt10unique_ptrINS4_12BlimpMessageESt14default_deleteIS8_EERKNS_8CallbackIFviELNS0_8CopyModeE1EEEEEEE8MakeItSoIJRKS6_SB_SH_EEEvSK_DpOT_                                                                                                                          
#6 0x000000584dbe _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIPFvNS_7WeakPtrIN5blimp22BlimpMessageThreadPipeEEESt10unique_ptrINS7_12BlimpMessageESt14default_deleteISB_EERKNS_8CallbackIFviELNS0_8CopyModeE1EEEEEESL_JRS9_NS0_13PassedWrapperISE_EERSI_EEENS0_12InvokeHelperILb0EvSN_EEFvvEE3RunEPNS0_13BindStateBaseE                  
#7 0x00000069c7fe base::Callback<>::Run()                                                                                                                                                      
#8 0x000007c7fbfe base::debug::TaskAnnotator::RunTask()                                                                                                                                        
#9 0x000007b11d6c base::MessageLoop::RunTask()                                                                                                                                                 
#10 0x000007b12008 base::MessageLoop::DeferOrRunPendingTask()                                                                                                                                  
#11 0x000007b12262 base::MessageLoop::DoWork()                                                                                                                                                 
#12 0x000007b2906c base::MessagePumpGlib::HandleDispatch()                                                                                                                                     
#13 0x000007b29831 base::(anonymous namespace)::WorkSourceDispatch()
#14 0x7f0e630eae04 g_main_context_dispatch
#15 0x7f0e630eb048 <unknown>
#16 0x7f0e630eb0ec g_main_context_iteration
#17 0x000007b2916f base::MessagePumpGlib::Run()
#18 0x000007b1175f base::MessageLoop::RunHandler()
#19 0x000007b90f44 base::RunLoop::Run()
#20 0x000000555c4a main
#21 0x7f0e5e0cdec5 __libc_start_main
#22 0x000000551bc5 <unknown>

This is because delegate_ is never set.

 

Comment 1 by w...@chromium.org, May 28 2016

Owner: w...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b1943d8eace94680d2fced00f872695801e192a

commit 4b1943d8eace94680d2fced00f872695801e192a
Author: wez <wez@chromium.org>
Date: Thu Jun 02 18:33:58 2016

Add a FakeImeFeatureDelegate to the Linux client.

The BlimpClientSession creates an ImeFeature which requires that a
Delegate be provided before the first IME message is received. Since the
Linux client is for developer testing only, we add a fake delegate which
just logs the IME show/hide requests.

This CL also corrects some BlimpMessageProcessor::ProcessMessage()
overrides to be public.

BUG= 615584 

Review-Url: https://codereview.chromium.org/2023613002
Cr-Commit-Position: refs/heads/master@{#397478}

[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/app/linux/blimp_client_session_linux.cc
[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/app/linux/blimp_client_session_linux.h
[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/feature/ime_feature.h
[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/feature/navigation_feature.h
[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/feature/render_widget_feature.h
[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/feature/settings_feature.h
[modify] https://crrev.com/4b1943d8eace94680d2fced00f872695801e192a/blimp/client/feature/tab_control_feature.h

Comment 3 by w...@chromium.org, Jun 3 2016

 Issue 610907  has been merged into this issue.

Comment 4 by w...@chromium.org, Jun 3 2016

Labels: OS-Linux
Status: Fixed (was: Started)
Labels: Archive-Blimp

Sign in to add a comment