New issue
Advanced search Search tips

Issue 615568 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Move //components/ui/zoom to top-level under //components

Project Member Reported by juncai@chromium.org, May 27 2016

Issue description

There is no pattern in //components of organizing individual components by logical module. So it's better to move //components/ui/zoom to top-level under //components.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a64f769c27e011b8304159cc4779592945278b64

commit a64f769c27e011b8304159cc4779592945278b64
Author: juncai <juncai@chromium.org>
Date: Sat Jun 04 00:55:32 2016

Move //components/ui/zoom to top-level under //components

There is no pattern in //components of organizing individual
components by logical module. This patch moved
//components/ui/zoom to top-level under //components.

BUG= 615568 

Review-Url: https://codereview.chromium.org/2019423005
Cr-Commit-Position: refs/heads/master@{#397871}

[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/BUILD.gn
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/browser_commands_unittest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/extensions/api/tabs/tabs_api.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/extensions/api/tabs/tabs_event_router.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/profiles/host_zoom_map_browsertest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/profiles/off_the_record_profile_impl.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/app_list/start_page_service.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/browser.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/browser.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/browser_unittest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/location_bar/zoom_decoration.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/cocoa/location_bar/zoom_decoration_unittest.mm
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/panels/panel_host.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/location_bar/zoom_view.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/location_bar/zoom_view.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/zoom/chrome_zoom_level_otr_delegate.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/zoom/chrome_zoom_level_prefs.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/zoom/zoom_controller_browsertest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/browser/ui/zoom/zoom_controller_unittest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/chrome_tests.gypi
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/test/BUILD.gn
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/BUILD.gn
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/components.gyp
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/components_tests.gyp
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/guest_view/browser/BUILD.gn
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/guest_view/browser/DEPS
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/guest_view/browser/guest_view_base.h
[delete] https://crrev.com/11476a3a92225f19419012e88bb2f7ae02b93e7c/components/ui/zoom/page_zoom_constants.cc
[delete] https://crrev.com/11476a3a92225f19419012e88bb2f7ae02b93e7c/components/ui_zoom.gypi
[add] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom.gypi
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/BUILD.gn
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/DEPS
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/OWNERS
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/page_zoom.cc
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/page_zoom.h
[add] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/page_zoom_constants.cc
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/page_zoom_constants.h
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/page_zoom_unittests.cc
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/test/DEPS
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/test/zoom_test_utils.cc
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/test/zoom_test_utils.h
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/zoom_controller.cc
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/zoom_controller.h
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/zoom_event_manager.cc
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/zoom_event_manager.h
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/zoom_event_manager_observer.h
[rename] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/components/zoom/zoom_observer.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/BUILD.gn
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/DEPS
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/extension_zoom_request_client.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/guest_view/extension_options/extension_options_guest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/browser/guest_view/web_view/web_view_guest.h
[modify] https://crrev.com/a64f769c27e011b8304159cc4779592945278b64/extensions/extensions.gyp

Status: Fixed (was: Started)

Sign in to add a comment