Add to the forthcoming URLRequestInterceptor logic for offline mode to show an offline page if the network quality estimator determines the effective connection type to be 2G-poor and the page is no older than one day.
Here's the URLRequestInterceptor cl: https://chromiumcodereview.appspot.com/2002433002/ See offline_page_request_handler.cc
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a699b6ea04c4e2d1413babc597fb2e01bc0261ec commit a699b6ea04c4e2d1413babc597fb2e01bc0261ec Author: ryansturm <ryansturm@chromium.org> Date: Wed Jul 20 18:56:45 2016 Exposing NQE on the Browser UI thread This involves an IO base observer which passes messages to the UI thread using a KeyedService. Consumers should be able to consume this similarly to the way the NQE is already consumed. BUG= 615563 Review-Url: https://codereview.chromium.org/2103323007 Cr-Commit-Position: refs/heads/master@{#406630} [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/OWNERS [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service.h [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.cc [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.h [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.cc [add] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/net/nqe/ui_network_quality_estimator_service_test_util.h [modify] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc [modify] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/chrome_browser.gypi [modify] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/chrome/chrome_tests.gypi [modify] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/a699b6ea04c4e2d1413babc597fb2e01bc0261ec/net/nqe/network_quality_estimator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4adf64f3261af5348c5675a8eace7453f319958c commit 4adf64f3261af5348c5675a8eace7453f319958c Author: ryansturm <ryansturm@chromium.org> Date: Thu Jul 28 18:51:56 2016 Adding a new component, Previews. This component will focus on reducing the data and page load performance footprint of loading pages by performing various optimizations to transform the content of those pages. This is being added to //components (rather than //chrome) because this will be consumed by //components/data_reduction_proxy/ and //components/offline_pages/. BUG= 615563 Review-Url: https://codereview.chromium.org/2179863003 Cr-Commit-Position: refs/heads/master@{#408444} [modify] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/BUILD.gn [modify] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/OWNERS [modify] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/components.gyp [modify] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/components_tests.gyp [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews.gypi [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/BUILD.gn [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/DEPS [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/OWNERS [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/PRESUBMIT.py [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/README [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/previews_experiments.cc [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/previews_experiments.h [add] https://crrev.com/4adf64f3261af5348c5675a8eace7453f319958c/components/previews/previews_experiments_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861 commit 9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861 Author: ryansturm <ryansturm@chromium.org> Date: Thu Jul 28 23:53:50 2016 Offline pages using NQE 2G Slow This allows use of the offline pages feature when on a prohibitively slow network. This feature is behind a FieldTrial. BUG= 615563 Review-Url: https://codereview.chromium.org/2166363003 Cr-Commit-Position: refs/heads/master@{#408511} [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/browser/BUILD.gn [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/browser/android/offline_pages/offline_page_tab_helper.h [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/browser/net/nqe/ui_network_quality_estimator_service.h [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/chrome/chrome_browser.gypi [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/components/previews/previews_experiments.cc [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/components/previews/previews_experiments.h [modify] https://crrev.com/9d5928c1f4cdfc2ce617c8c4c0c925951a5eb861/components/previews/previews_experiments_unittest.cc
This is behind the ClientSidePreviews/Enabled fieldtrial/group with "show_offline_pages" = "true" in the params.
Comment 1 by megjab...@chromium.org
, Jun 23 2016Owner: ryansturm@chromium.org