New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615554 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mus needs to support snapping windows to pixel boundaries

Project Member Reported by sky@chromium.org, May 27 2016

Issue description

I suspect it makes the most sense to implement this in mus, but I'm not positive. See WmWindowMus::SnapToPixelBoundaryIfNecessary() and SetSnapsChildrenToPhysicalPixelBoundary().
 
Components: Internals>MUS
Labels: Proj-Mustash

Comment 2 by sky@chromium.org, Jan 4 2017

Cc: fsam...@chromium.org sadrul@chromium.org
Labels: -Proj-Mustash Proj-Mustash-Mash
I've removed the WmWindowMus overrides, so this ends up using the WmWindowAura code, which calls to window_util. window_util up setting the window property kSnapChildrenToPixelBoundary and calling ui::SnapLayerToPhysicalPixelBoundary to adjust the layer. This may be ok to leave in ash as only ash calls SetSnapsChildrenToPhysicalPixelBoundary.

Sadrul/Fady, are the calls to ui::SnapLayerToPhysicalPixelBoundary ok to have only in ash? The code should only be calling this for layers created in ash, but they may be embed points.

Comment 3 by sky@chromium.org, Mar 7 2017

Status: WontFix (was: Available)
As ash handles the layout of everything this is no longer applicable.
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment