New issue
Advanced search Search tips

Issue 615552 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 644860



Sign in to add a comment

WmWindowMus needs to support SetBoundsInScreen and associated BoundsInScreenBehavior

Project Member Reported by sky@chromium.org, May 27 2016

Issue description

See ash's ScreenPositionController for what this should do.
 
Components: MUS

Comment 2 by sky@chromium.org, Sep 7 2016

Blockedon: 644860
Labels: -WindowManager Proj-Mustash-Mash
Cc: jamescook@chromium.org
Relates to  issue 645291  NativeWidgetMus::SetBounds() should support moving widgets between displays.

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aecdb0fbad617472bd1d5d393ea89b9257fdca66

commit aecdb0fbad617472bd1d5d393ea89b9257fdca66
Author: sky <sky@chromium.org>
Date: Thu Sep 15 22:14:28 2016

Wires up WmWindowMus::SetBoundsInScreen()

As part of this I realized SetLockedToRoot and
SetDescendantsStayInSameRootWindow meant the same thing, so I nuked
the later.

In order to test this I need multiple display support, which isn't
quite working yet (in particular shutdown is currently
problematic).

BUG= 615552 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2344783002
Cr-Commit-Position: refs/heads/master@{#419010}

[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/aura/wm_window_aura.h
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/common/wm/window_positioning_utils.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/common/wm/window_positioning_utils.h
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/common/wm_window.h
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/display/screen_position_controller.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/wm/window_properties.cc
[modify] https://crrev.com/aecdb0fbad617472bd1d5d393ea89b9257fdca66/ash/wm/window_properties.h

Comment 5 by sky@chromium.org, Sep 20 2016

Owner: sky@chromium.org
Status: Fixed (was: Available)
This is fixed.

Comment 6 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment