New issue
Advanced search Search tips

Issue 615551 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move Lo-Fi to the new NQE API

Project Member Reported by tbansal@chromium.org, May 27 2016

Issue description

This bug tracks moving Lo-Fi trigger logic to the new NQE API: GetEffectiveConnectionType. The plan is to port the Lo-Fi trigger logic to NQE's API. Then, Lo-Fi can call the NQE API to get the effective connection type, and trigger based on that.

Once that's done, NQE can perform experiments with different implementations of API. That work will be tracked elsewhere.
 
Components: Internals>Network>DataProxy
Project Member

Comment 2 by bugdroid1@chromium.org, May 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94f611885fe6ae218aa146c17d1df4c07e35f4af

commit 94f611885fe6ae218aa146c17d1df4c07e35f4af
Author: tbansal <tbansal@chromium.org>
Date: Sat May 28 00:07:27 2016

Expose a method GetRecentEffectiveConnectionType in NQE.

This method is private and will be used for computing the
accuracy of NQE.

Also, remove some duplicate code in the existing methods.

BUG= 615551 

Review-Url: https://codereview.chromium.org/2003423005
Cr-Commit-Position: refs/heads/master@{#396606}

[modify] https://crrev.com/94f611885fe6ae218aa146c17d1df4c07e35f4af/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/94f611885fe6ae218aa146c17d1df4c07e35f4af/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/94f611885fe6ae218aa146c17d1df4c07e35f4af/net/nqe/network_quality_estimator_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599e0cae220ae619be4039ef8cbb45069e188038

commit 599e0cae220ae619be4039ef8cbb45069e188038
Author: tbansal <tbansal@chromium.org>
Date: Wed Jun 08 00:14:43 2016

Record NQE accuracy at main frame requests

At each main frame request, NQE estimates are preserved
locally. Then, the observed network quality is computed
from the observations received in the next 15, 30 and 60
seconds. The preserved estimates are compared against the
observed estimates, and the computed accuracy is recorded
using UMA.

Design doc here: https://docs.google.com/document/d/18dA6DmUdh8DxwWutR-hFcd2K4yVJvqDIot6291etf6E/view

BUG= 615551 

Review-Url: https://codereview.chromium.org/2020353002
Cr-Commit-Position: refs/heads/master@{#398428}

[modify] https://crrev.com/599e0cae220ae619be4039ef8cbb45069e188038/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/599e0cae220ae619be4039ef8cbb45069e188038/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/599e0cae220ae619be4039ef8cbb45069e188038/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/599e0cae220ae619be4039ef8cbb45069e188038/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d1c6a86c81451dabc92c3450348b329ff1290a

commit a1d1c6a86c81451dabc92c3450348b329ff1290a
Author: tbansal <tbansal@chromium.org>
Date: Thu Jun 09 01:10:53 2016

NQE: Allow algorithm to be set using variation params

This CL provides the ability to use different algorithms for
computing effective connection type. The algorithm to use
can be set using field trial params. If field trial params
are unavailable (e.g., at first run), then a default value
is used.

The existing algorithm was also modified to be exactly same
as what data reduction proxy is currently is using.

Once this CL lands, the server side CL needs to land to set
the variation param. Then, GetEffectiveConnectionType() API
will be ready for use by DRP and custom fonts.

BUG=	 615551 , 569497 

Review-Url: https://codereview.chromium.org/2032443003
Cr-Commit-Position: refs/heads/master@{#398753}

[modify] https://crrev.com/a1d1c6a86c81451dabc92c3450348b329ff1290a/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/a1d1c6a86c81451dabc92c3450348b329ff1290a/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/a1d1c6a86c81451dabc92c3450348b329ff1290a/net/nqe/network_quality_estimator_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75e7e4989cba8fc6a937b842955a4fb893881ed8

commit 75e7e4989cba8fc6a937b842955a4fb893881ed8
Author: tbansal <tbansal@chromium.org>
Date: Mon Jun 20 21:22:57 2016

Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG= 615551 

Review-Url: https://codereview.chromium.org/2064763003
Cr-Commit-Position: refs/heads/master@{#400783}

[modify] https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8/net/nqe/network_quality_estimator_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b44b0d04552b1fa23c653196a8d33bf30f477e07

commit b44b0d04552b1fa23c653196a8d33bf30f477e07
Author: tbansal <tbansal@chromium.org>
Date: Mon Jun 27 19:29:49 2016

Change the visibility of NQE public functions

These functions expose raw metrics such as estimated HTTP
RTT, transport RTT, bandwidth. They can now all be
"protected" since data reduction proxy has switched to
GetEffectiveConnectionType().

BUG= 615551 

Review-Url: https://codereview.chromium.org/2093493002
Cr-Commit-Position: refs/heads/master@{#402254}

[modify] https://crrev.com/b44b0d04552b1fa23c653196a8d33bf30f477e07/net/nqe/network_quality_estimator.h

Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality

Sign in to add a comment