New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615543 link

Starred by 1 user
Status: Fixed
Owner:
█ olka@chromium.org
OOO Dec 22 - Jan 8
Closed: May 2016
Cc:
creis@chromium.org
dalecur...@chromium.org
wfh@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

AudioRendererSinkCacheTest.SmokeTest flaky on Site Isolation Win FYI bot

Project Member Reported by creis@chromium.org, May 27 2016 
The AudioRendererSinkCacheTest.SmokeTest was added to content_unittests in https://codereview.chromium.org/1942803002.  After two successful builds on the Site Isolation Win FYI bot (14746 and 14747), it failed in the third build:

https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/14748

This bot just runs the tests with --site-per-process, to make out-of-process iframes possible for cross-site pages.  Not sure if that mode actually affects this test, or if it's just flaky in general.  olka@, can you take a look and disable/revert if necessary?

Build output (not sure why it's missing so many characters; must be an unrelated bug):

e:uild\slave\site_isolation_winuild\src\mediaase	est_helpers.cc(122): error: Failed
Timed out waiting for message loop to quit
e:uild\slave\site_isolation_winuild\src\mediaase	est_helpers.cc(105): error: Value of: signaled_
  Actual: false
Expected: true

Comment 1 by olka@chromium.org, May 28 2016 

Looks like for some reason the test took too long and was killed after a timeout at 15.6 seconds. Test itself reported no problems and it looks like the execution flow was normal (lots of gmock warnings, as expected). It takes ~4 seconds on my machine, so this is most likely because of configuration specifics.
Need to figure out how to deal with that, will ask for advice.

Comment 2 by olka@chromium.org, May 30 2016

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28b5bbb227d331c01e6ff9b2f8729732135aadc7

commit 28b5bbb227d331c01e6ff9b2f8729732135aadc7
Author: olka <olka@chromium.org>
Date: Mon May 30 13:09:54 2016

Reducing AudioRendererSinkCache delete timeout for testing. This reduces unit test execution time ~twice.

BUG= 615543 

Review-Url: https://codereview.chromium.org/2026513002
Cr-Commit-Position: refs/heads/master@{#396720}

[modify] https://crrev.com/28b5bbb227d331c01e6ff9b2f8729732135aadc7/content/renderer/media/audio_renderer_sink_cache_unittest.cc

Comment 4 by olka@chromium.org, May 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment