New issue
Advanced search Search tips

Issue 615542 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 620852



Sign in to add a comment

HttpProxyClientSocket: Clean up stuff used to establish the connection, once we have one.

Project Member Reported by mmenke@chromium.org, May 27 2016

Issue description

HttpProxyClientSocket keeps around request and response headers, an HttpStreamParser, and the IOBuffer used to read the headers, after we've successfully established a connection.  None of these is ever used again.  We should just clean up all of these.

The memory here isn't huge - maybe say, 1.4 k for the read buffer, ~100 bytes for the request and the response headers, ~80 bytes for the rest of the ResponseInfo, so let's just round it to about 2k per socket, assuming I'm not missing anything big.  And most people don't even use proxies.  With 32 sockets (Assuming one proxy), that's a max of about 64k, which isn't huge, even on mobile, where proxies are probably even less common.

That said, it's completely trivial to free (most?) of this stuff on successful tunnel connection establishment - we may still need SSLInfo from the ResponseInfo or something, so have to be careful about the exposed API.

 

Comment 1 by mmenke@chromium.org, Oct 11 2016

Blocking: 620852
Cc: mmenke@chromium.org
Owner: ----
Status: Available (was: Assigned)
Not sure this is worth the effort.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 12 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)
Archiving this bug. I don't think we the cycles to handle this. 

Sign in to add a comment