New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615535 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
no longer active
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 654046
issue 656025



Sign in to add a comment

[MD Feedback] Implement WebUI scaffolding.

Project Member Reported by apaci...@chromium.org, May 27 2016

Issue description

This bug tracks implementing the front end/scaffolding for the feedback WebUI in Polymer. This does not track integration with the feedback backend.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20deb53f9df11c8a5967f34ac07d911138f0a153

commit 20deb53f9df11c8a5967f34ac07d911138f0a153
Author: apacible <apacible@chromium.org>
Date: Fri Jun 10 22:26:47 2016

[Md Feedback] Add initial content/strings to feedback-container element.

Changes include:
- Create feedback-container custom Polymer element with initial contents/strings and very minimal styling.
- String localization. The strings are primarily duplicates of the existing feedback, which avoids messiness if/when one set of strings are modified.
- Add newly used resources to polymer_resources.grdp.

WebUI interaction/functionality implemented later.

BUG= 615535 ,  606844 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2039593002
Cr-Commit-Position: refs/heads/master@{#399296}

[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/app/generated_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/browser_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.js
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20deb53f9df11c8a5967f34ac07d911138f0a153

commit 20deb53f9df11c8a5967f34ac07d911138f0a153
Author: apacible <apacible@chromium.org>
Date: Fri Jun 10 22:26:47 2016

[Md Feedback] Add initial content/strings to feedback-container element.

Changes include:
- Create feedback-container custom Polymer element with initial contents/strings and very minimal styling.
- String localization. The strings are primarily duplicates of the existing feedback, which avoids messiness if/when one set of strings are modified.
- Add newly used resources to polymer_resources.grdp.

WebUI interaction/functionality implemented later.

BUG= 615535 ,  606844 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2039593002
Cr-Commit-Position: refs/heads/master@{#399296}

[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/app/generated_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/browser_resources.grd
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.html
[add] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/resources/md_feedback/feedback_container.js
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc
[modify] https://crrev.com/20deb53f9df11c8a5967f34ac07d911138f0a153/ui/webui/resources/polymer_resources.grdp

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56407438c13ba0a08766d048725cf038a1e0ee7d

commit 56407438c13ba0a08766d048725cf038a1e0ee7d
Author: apacible <apacible@chromium.org>
Date: Mon Jul 25 23:54:30 2016

[Md Feedback] Add the rest of existing strings.

This change adds the rest of the strings of the feedback form we'll be using. These strings are copied from the current feedback form; we opt to create new strings in case they're modified in the future, as to not disrupt the current feedback flow.

The remaining missing strings (i.e. for file upload) correspond to components that are not planned for the redesign.

No additional styling work has been done; this will be done when the feedback form is also migrated to a dialog.

BUG= 615535 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2163753003
Cr-Commit-Position: refs/heads/master@{#407636}

[modify] https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d/chrome/app/generated_resources.grd
[modify] https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d/chrome/browser/resources/md_feedback/feedback_container.html
[modify] https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d/chrome/browser/resources/md_feedback/feedback_container.js
[modify] https://crrev.com/56407438c13ba0a08766d048725cf038a1e0ee7d/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc

Blockedon: 656025
Blockedon: 654046
Status: Archived (was: Started)

Sign in to add a comment