[MD Feedback] Set up WebUI components. |
||
Issue descriptionThis bug tracks implementing the feedback WebUI components, including: - chrome://feedback. - Opening the WebUI in a dialog.
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc877565b2977c7e8771eadb65afcecfeb8660e2 commit cc877565b2977c7e8771eadb65afcecfeb8660e2 Author: apacible <apacible@chromium.org> Date: Fri Jun 03 00:17:44 2016 [MD Feedback] Add basic chrome://feedback dialog. This adds a basic dialog delegate and controller to house the feedback WebUI. The dialog is not anchored or constrained to any other browser window. Show() is only implemented for views. Mac will be done in a separate patch. BUG= 615533 Review-Url: https://codereview.chromium.org/2021753005 Cr-Commit-Position: refs/heads/master@{#397556} [modify] https://crrev.com/cc877565b2977c7e8771eadb65afcecfeb8660e2/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc [modify] https://crrev.com/cc877565b2977c7e8771eadb65afcecfeb8660e2/chrome/browser/ui/webui/md_feedback/md_feedback_ui.h
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ef2fc0dbea076597d474315e15bae6fffb12de8 commit 7ef2fc0dbea076597d474315e15bae6fffb12de8 Author: apacible <apacible@chromium.org> Date: Wed Aug 10 04:40:02 2016 [MD Feedback] Add placeholder feedback entry point. This change adds a placeholder entry point for the redesigned feedback dialog. This makes it easy to do preliminary manual testing. This does not affect the current feedback UI. Pulled out MdFeedbackDialogDelegate and created a Controller (more to come) to be able to create and show the dialog, as there should be a way to determine whether to create a new dialog or bring an existing one to the front depending on the current browser profile. That work TBD, as we're still investigating how to determine the dialog-to-profile mapping. BUG= 615533 Review-Url: https://codereview.chromium.org/2159323003 Cr-Commit-Position: refs/heads/master@{#410955} [modify] https://crrev.com/7ef2fc0dbea076597d474315e15bae6fffb12de8/chrome/browser/feedback/show_feedback_page.cc [add] https://crrev.com/7ef2fc0dbea076597d474315e15bae6fffb12de8/chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.cc [add] https://crrev.com/7ef2fc0dbea076597d474315e15bae6fffb12de8/chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.h [modify] https://crrev.com/7ef2fc0dbea076597d474315e15bae6fffb12de8/chrome/browser/ui/webui/md_feedback/md_feedback_ui.cc [modify] https://crrev.com/7ef2fc0dbea076597d474315e15bae6fffb12de8/chrome/chrome_browser_ui.gypi
,
Sep 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2016