MD Ink Drop "stuck" on toolbar button if, while the space bar is held down the arrow keys select another button |
|||
Issue descriptionVersion: 53.0.2750.0 OS: Windows 8.1 & 10 What steps will reproduce the problem? (1) Make sure at least two toolbar buttons are visible and enabled. (2) Shift-Alt-T to select focus one of the toolbar buttons (3) Press and hold the space bar (MD Inkdrop should be visible) (4) While still holding down the space bar, press the right or left arrow key to select another button (5) Release the space bar. EXPECTED: Ink Drop should disappear and spacebar down state should be cancelled. ACTUAL: Ink Drop is "stuck" on and the newly selected button is triggered instead of nothing. Please use labels and text to provide additional information.
,
May 27 2016
Yes, I was planning looking at this, but wanted to get it tracked first.
,
May 27 2016
Hmm I take that back it probably wasn't caused by issue 591140 .
,
May 27 2016
When focus is shifted to another button, the Ink drop ripple isn't shown, however when the space bar is released the newly selected button's click behavior is triggered. This behavior should change to hiding the Ink drop ripple on the original button and releasing the space bar should do nothing on the newly selected button. IOW, the "click" notification should fire only if the button was previously "armed" in the "pressed" state. Additionally, we can consider the use of <ESC> to also cancel the pressed or "armed" state of the button even while it remains focused. Normally, <ESC> isn't processed directly, rather a WM_CANCELMODE message is generated. This message is then processed to cancel any currently active "modes" such as an armed key press, an open popup menu, an active "in-place" editing mode, etc... Since what I outlined above seems to be normal Windows behavior, there should be minimal impact on accessibility: Need to get agreement from dmazzoni@.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/934405233ea138ad8c27528779b6f9071957b8bc commit 934405233ea138ad8c27528779b6f9071957b8bc Author: kylixrd <kylixrd@chromium.org> Date: Thu Jun 02 19:58:43 2016 Fixes losing focus while space bar pressed. BUG= 615520 Review-Url: https://codereview.chromium.org/2017833003 Cr-Commit-Position: refs/heads/master@{#397492} [modify] https://crrev.com/934405233ea138ad8c27528779b6f9071957b8bc/ui/views/animation/test/test_ink_drop_delegate.cc [modify] https://crrev.com/934405233ea138ad8c27528779b6f9071957b8bc/ui/views/animation/test/test_ink_drop_delegate.h [modify] https://crrev.com/934405233ea138ad8c27528779b6f9071957b8bc/ui/views/controls/button/custom_button.cc [modify] https://crrev.com/934405233ea138ad8c27528779b6f9071957b8bc/ui/views/controls/button/custom_button_unittest.cc
,
Jun 8 2016
Allen, is this Fixed now?
,
Jun 8 2016
Yes. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bruthig@chromium.org
, May 27 2016Labels: M-53 Proj-MaterialDesign-NativeUI OS-Chrome OS-Linux
Owner: kylixrd@chromium.org
Status: Assigned (was: Untriaged)