Issue metadata
Sign in to add a comment
|
webview crashed on attempt to scroll |
||||||||||||||||||||||
Issue descriptionOS: ChromeOS What steps will reproduce the problem? Open Arc++ OptIn UI (real ChromeOS device). It contains embedded webview that displays ToS of PlayStore. Try to scroll using 2-fingers gesture via touchpad or using touchscreen. What is the expected output? Webview content is scrolled. What do you see instead? Webview crashes or no scroll.
,
May 27 2016
I am creating CL now, as I see from the code this is very old bug.
,
May 27 2016
,
Jun 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d92694016e4cc9f7812894aa60eb4d36de6cd381 commit d92694016e4cc9f7812894aa60eb4d36de6cd381 Author: khmel <khmel@chromium.org> Date: Sat Jun 04 03:59:34 2016 Fix webview crash on attempt to scroll. This fixes crash of webview when its content is scrolled using 2-fingers gesture via touchpad or using touchscreen. BUG= 615512 TEST=Manually on device using Arc++ OptIn UI, ToS is scrolled as expected using touchscreen or touchpad, no crashes. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2015373002 Cr-Commit-Position: refs/heads/master@{#397901} [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.html [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.html [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.js [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/content/public/test/browser_test_utils.cc [modify] https://crrev.com/d92694016e4cc9f7812894aa60eb4d36de6cd381/content/public/test/browser_test_utils.h
,
Jun 4 2016
,
Jun 7 2016
Please merge this patch to M52, which is currently still broken.
,
Jun 7 2016
Issue 614627 has been merged into this issue.
,
Jun 7 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 7 2016
Issue 617487 has been merged into this issue.
,
Jun 7 2016
Issue 617021 has been merged into this issue.
,
Jun 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b35e91ce0b567bc4b337124c63d7d6359cce27 commit 72b35e91ce0b567bc4b337124c63d7d6359cce27 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Jun 07 16:57:05 2016 Merge "Fix webview crash on attempt to scroll." > This fixes crash of webview when its content is scrolled using > 2-fingers gesture via touchpad or using touchscreen. > > BUG= 615512 > TEST=Manually on device using Arc++ OptIn UI, ToS is scrolled > as expected using touchscreen or touchpad, no crashes. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2015373002 > Cr-Commit-Position: refs/heads/master@{#397901} > (cherry picked from commit d92694016e4cc9f7812894aa60eb4d36de6cd381) Review URL: https://codereview.chromium.org/2046843003 . Cr-Commit-Position: refs/branch-heads/2743@{#263} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.html [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.html [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.js [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/content/public/test/browser_test_utils.cc [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/content/public/test/browser_test_utils.h
,
Jun 8 2016
Tested the issue on Peppy using chrome version 52.0.2743.33/8350.23.0 with the steps mentioned in merged bug 614627 . Not seeing any flicker on scrolling hangouts app and pdf as well. adding TE-Verified label. Thanks,
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b35e91ce0b567bc4b337124c63d7d6359cce27 commit 72b35e91ce0b567bc4b337124c63d7d6359cce27 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Jun 07 16:57:05 2016 Merge "Fix webview crash on attempt to scroll." > This fixes crash of webview when its content is scrolled using > 2-fingers gesture via touchpad or using touchscreen. > > BUG= 615512 > TEST=Manually on device using Arc++ OptIn UI, ToS is scrolled > as expected using touchscreen or touchpad, no crashes. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2015373002 > Cr-Commit-Position: refs/heads/master@{#397901} > (cherry picked from commit d92694016e4cc9f7812894aa60eb4d36de6cd381) Review URL: https://codereview.chromium.org/2046843003 . Cr-Commit-Position: refs/branch-heads/2743@{#263} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.html [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/guest.js [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.html [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/chrome/test/data/extensions/platform_apps/web_view/scrollable_embedder_and_guest/main.js [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/content/public/test/browser_test_utils.cc [modify] https://crrev.com/72b35e91ce0b567bc4b337124c63d7d6359cce27/content/public/test/browser_test_utils.h
,
Jun 23 2016
Issue 614628 has been merged into this issue.
,
Jun 29 2016
ChromeOS:8517.0.0/53.0.2773.0
,
Jun 29 2016
Issue 614830 has been merged into this issue.
,
Jul 8 2016
,
Jul 19 2016
I can still reproduce following issues which were merged to this issue. Issue 617021 : Internal pdf / Hangouts App doesn't scroll, it only *flings* (ie, page only moves after lifting fingers from trackpad) Issue 625776 : Regression: Available services window is seen crashing in Files.app And we get one more similar bug. Issue 628978 : Share overlay is crashing in Files.app I reproduced all of them using Chromebook Flip with ChromeOS:8601.0.0/54.0.2798.0 Let me reopen this bug. khmel@, could you check the issues above? If they look unrelated to this bug, could you unmerge them?
,
Jul 19 2016
Regarding 617021, I reproduced the crash issue, not the non-responding issue. That is, Issue 617487 : Internal pdf / Hangouts App crashes on touchscreen event after attempted scroll
,
Jul 19 2016
Will take a look,
,
Jul 19 2016
adding one more item to track: 627623
,
Jul 19 2016
I've changed 617021 to be a duplicate of 601875, which I'm currently working on (and that I know the root cause of).
,
Jul 19 2016
I am closing this issue. Reason of crash of bugs listed here is different. There is CL in 627623. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xiy...@chromium.org
, May 27 2016