New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615511 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ gunaa@google.com
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Add token field to ClientSafeBrowsingReportRequest

Project Member Reported by jialiul@chromium.org, May 27 2016 
Add token field to ClientSafeBrowsingReportRequest to help link download ping to download ctr report.
The token field contains the same info as ClientDownloadResponse.token that can uniquely identify a download activity. 
https://cs.corp.google.com/piper///depot/google3/quality/trustrank/frontend/csdserver/csd_client.proto?l=798&gs=proto%253Afield-quality_trustrank.ClientDownloadResponse.token%2540google3%252Fquality%252Ftrustrank%252Ffrontend%252Fcsdserver%252Fcsd_client.proto&gsn=token&ct=xref_usages

Comment 1 by vakh@chromium.org, Jun 3 2016

Labels: SafeBrowsing-Triaged
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c26385851a2425cb68a47da7f420c04e28b6c45

commit 2c26385851a2425cb68a47da7f420c04e28b6c45
Author: jialiul <jialiul@chromium.org>
Date: Wed Jun 08 22:18:08 2016

Add token field to ClientSafeBrowsingReportReqeust.

In order to calculate CTRs of bad downloads, safe browsing needs information to
link ClientSafeBrowsingReportRequest (for downloads) and ClientDownloadResponse.
To achieve this, we add a token field to identify its corresponding
ClientDownloadResponse in the ClientSafeBrowsingReportRequest, and propagate it
with the same string in ClientDownloadResponse.token.

Also add a new download report type (DANGEROUS_DOWNLOAD_BY_API) to separately
track CTR of dangerous downloads go through download API.

BUG= 615511 

Review-Url: https://codereview.chromium.org/2029903002
Cr-Commit-Position: refs/heads/master@{#398699}

[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/download/download_danger_prompt.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/download/download_danger_prompt.h
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/safe_browsing/download_protection_service.h
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/browser/ui/views/download/download_danger_prompt_views.cc
[modify] https://crrev.com/2c26385851a2425cb68a47da7f420c04e28b6c45/chrome/common/safe_browsing/csd.proto

Comment 3 by jialiul@chromium.org, Jun 8 2016

Status: Fixed (was: Started)

Comment 4 by jialiul@chromium.org, Jun 10 2016

Labels: Merge-Request-52
Safe browsing backend has already received updated reports from Canary channel. Everything looks good. 
Request merge to M52 stable. 

Thanks!

Comment 5 by tin...@google.com, Jun 10 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)

Comment 6 by jialiul@chromium.org, Jun 10 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-52
Remove merge request due to lots of dependency conflicts.
►

Sign in to add a comment