Frequent crashes with certain http2 configurations
Reported by
g.rossol...@gmail.com,
May 27 2016
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.63 Safari/537.36 Example URL: instantluxe.co.uk Steps to reproduce the problem: 1. browse a few pages 2. before 5 to 10 pageloads, chances are you will have reproduced the problem What is the expected behavior? Not crash What went wrong? Chrome displays its "aw snap" page. Reloading usually displays the page as expected. Did this work before? Yes Before Chrome was updated to v51 Chrome version: 51.0.2704.63 Channel: stable OS Version: OS X 10.11.5 Flash Version: Shockwave Flash 21.0 r0 While logging with the startup flag on a Windows 10 machine, we noticed NUL characters being logged in several response headers. These characters are not present in the server configuration files. While this issue is being debugged, only the www domain is currently configured with http2 for the .co.uk TLD; subdomains are not, and neither are the translations. More details are provided in the attached data dump. DNT headers can be used to disable any external assets, but that doesn't solve the problem. Looking at the data dump, it seems the browser received a HTTP/1.1 200 response (instead of HTTP/2 200) on the URL that triggered the crash. I am not sure why that happened, but it does not seem to have caused the crash.
,
May 31 2016
I've reproduced the issue by browsing around instantluxe.co.uk on my linux machine and reported https://bugs.chromium.org/p/chromium/issues/detail?id=616190 for the crash with Crash ID ef03aaaa00000000
,
May 31 2016
Thanks for reproducing. Can we disable http2 now on the website, so our customers aren't affected by the issue?
,
May 31 2016
Yes, I think you should disable HTTP/2 at this point. I'll try to investigate based on the crash and net-internals. Thank you.
,
May 31 2016
Thanks, done. Please let me know if you need me to re-enable it for further investigation.
,
May 31 2016
I cannot reproduce this crash with neither Debug nor Release locally-built Chrome 53.0.2754.0. Could you try this on Canary or Dev channel (https://www.chromium.org/getting-involved/dev-channel) to confirm?
,
May 31 2016
Hrm, just reading comment 5 I wonder whether my recent non-reproduction is the result of HTTP/2 being disabled on the site and not of different Chrome version.
,
Jun 1 2016
I just re-enabled h2 on the server to check Version 53.0.2754.0 canary (64-bit) on a Win10 machine: the crash is still present. h2 is disabled again on the host.
,
Jun 1 2016
,
Jun 24 2016
I'd like to help you diagnose the problem if I can. How can I help? (I can't see #616190)
,
Jul 1 2016
,
Sep 17 2016
g.rossolini@ would it be possible for you to bring up a cnamed host (h2.yourdomain.com) with h2 enabled, so we can diagnose this?
,
Sep 17 2016
Sure, please use www.instantluxe.cn.
,
Sep 19 2016
I cannot reproduce the crash when browsing www.instantluxe.cn with Chrome Dev 55.0.2859.0. I confirm that HTTP/2 is used. If anybody sees the crash, please post the crash ID from chrome://crashes/.
,
Sep 19 2016
,
Sep 21 2016
I just tried again with both 53.0.2785.116 (64-bit) and Version 55.0.2867.0 canary (64-bit). Canary does not crash any more, while Stable still crashes. I am guessing something has been done to resolve this?
,
Sep 22 2016
It is possible that this crash got fixed in the meanwhile. Note, however, that right now I cannot reproduce the crash with either 55.0.2859.0 or 53.0.2785.116, both 64 bit on Linux, browsing www.instantluxe.cn for five minutes, even though HTTP/2 was negotiated in both cases.
,
Sep 24 2016
Is it possible to know what Chrome version comes with the fix and whether the fix was accidental? With macOS, Version 53.0.2785.116 (64-bit) still crashes after a few pageloads on www.instantluxe.cn while Version 55.0.2870.0 canary (64-bit) is stable.
,
Sep 26 2016
One could bisect to find the change that fixed the crash, and that would tell us what version comes with the fix and whether it was accidental. However, given that one can browse for many minutes without encountering the crash, this approach would be infeasible.
,
Sep 26 2016
Marking as fixed as the OP reports that 55.0.2870.0 does not crash.
,
Sep 26 2016
Comment #2 could reproduce the issue at the time. Would you mind getting in touch with that person to make sure we're not missing anything? Without bisecting anything, Issue #616190 was reported because of this here, so I guess resolution could be tracked from there? I can't attach a crash ID when browsing with a guest user, but I am attaching two net-internals reports saved from two user sessions with Version 53.0.2785.116 (64-bit) (on macOS Sierra Version 10.12 (16A323)). My take on this bug is that at some point, the connection is negotiated as HTTP/1.1 instead of HTTP/2, and that causes the crash.
,
Oct 29 2016
This is just to let you know we've enabled h2 again for the last week, and everything seems stable. We have no feedback about issues on this, nor have we noticed any ourselves. (I am using stable v54.0.2840.71 (64-bit) at the moment) Thanks for the fix!
,
Nov 1 2016
Re #22: Thank you for reporting back. Please file a new bug if you experience any issues. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by meh...@chromium.org
, May 27 2016Labels: Stability-Crash