New issue
Advanced search Search tips

Issue 615495 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 343579



Sign in to add a comment

Add histograms to record count of requests that were fetched successfully via different DRP proxies

Project Member Reported by tbansal@chromium.org, May 27 2016

Issue description

We should add histogram to record how many requests were successfully fetched via different data reduction proxies. e.g., how many requests were successfully fetched via primary proxy, secondary proxy etc. This would help in multiple ways:
(i) Quantifying if using QUIC has any effect on how frequently primary proxy is used.
(ii) Detecting any regression in use of primary proxy.
(iii) Once the flywheel config server starts sending more than 2 proxies in the configuration, it will be useful to see how frequently the third proxy is used, and if that fallback mechanism is working correctly or not.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a89e4db53afe3a849700af9ac981de529d4258b

commit 9a89e4db53afe3a849700af9ac981de529d4258b
Author: tbansal <tbansal@chromium.org>
Date: Fri May 27 23:36:49 2016

Add histograms for requests that were fetched successfully

Add histograms for requests that were fetched successfully
through data reduction proxy. Also, replace is_fallback by
proxy_index in DataReductionProxyTypeInfo.

BUG= 615495 

Review-Url: https://codereview.chromium.org/2019783002
Cr-Commit-Position: refs/heads/master@{#396598}

[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/9a89e4db53afe3a849700af9ac981de529d4258b/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Blocking: 343579

Sign in to add a comment