Include user_timing marks in the trace |
||
Issue descriptionCurrently we only get usertiming measures in the trace. YouTube and others have usecases for getting marks in the trace as well. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp&q=f:performanceusertiming%20%20TRACE_EVENT_COPY_MARK%5C(%5C%22blink.user_timing&sq=package:chromium&type=cs I don't follow what's happening with TRACE_EVENT_COPY_MARK, but is it possible to make sure we get a trace_event logged into the trace for the solo mark (as well as measures)?
,
May 27 2016
All Start
,
May 31 2016
Paul, could you describe what you mean by "solo mark"? My understanding is that right now we have marks written into the trace for some of the predefined-by-the-standard marks, all user-defined marks, and all measures as long as blink.user_timing is working. https://crbug.com/599135 the tracking bug for "get marks issued for ALL predefined-by-the-standard marks". Work on it currently isn't started and is constantly getting pushed back by power-infra related work, but I can do my best to schedule the work in a real way if there's a need for it.
,
May 31 2016
Also, to clarify: by "as long as blink.user_timing is working", I mean "as long as we're tracing with the blink.user_timing category enabled"
,
Jun 1 2016
> My understanding is that right now we have marks written into the trace for some of the predefined-by-the-standard marks, all user-defined marks, and all measures as long as blink.user_timing is working. Yup I looked again and I'm seeing the marks in the trace. Not sure why I thought they were missing. Thanks!
,
Jun 13 2016
Good deal. Thanks for closing! |
||
►
Sign in to add a comment |
||
Comment 1 by paulir...@chromium.org
, May 27 2016