Ship Widevine CDM on official Mac GN build. |
||||
Issue descriptionToday on Mac in gyp build, we put the Widevine CDM in <output dir>/WidevineCdm/_platform_specific/mac_x64/ folder, then copy it into the bundle. In GN build, the second part is missing, so we are missing the CDMs in the bundle.
,
May 27 2016
,
May 27 2016
rsesek@chromium.org: I remember that on Mac GN build, even in tests, AmIBundled() always returns true. Is that correct? If so, our browser tests should be able to use the CDM in the bundle as well.
,
May 27 2016
Yes, browser_tests use SetOverrideAmIBundled(). Not all test targets do, though.
,
Jun 2 2016
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34a7667c244f3d912d7dbbdfde37331b09f88efc commit 34a7667c244f3d912d7dbbdfde37331b09f88efc Author: rsesek <rsesek@chromium.org> Date: Fri Jun 03 22:51:44 2016 [Mac/GN] Include WidevineCdm for Chrome builds. BUG= 615486 R=xhwang@chromium.org Review-Url: https://codereview.chromium.org/2033923002 Cr-Commit-Position: refs/heads/master@{#397830} [modify] https://crrev.com/34a7667c244f3d912d7dbbdfde37331b09f88efc/chrome/BUILD.gn
,
Jun 4 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rsesek@chromium.org
, May 27 2016