New issue
Advanced search Search tips

Issue 615466 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 537368



Sign in to add a comment

GCC does not recognize -Wno-unknown-warning-option

Project Member Reported by llozano@chromium.org, May 27 2016

Issue description

I added -Wno-unknown-warning-option a week or so ago. 
I thought this was a valid option for both Clang and GCC. It turns out it is only supported by Clang. GCC does not support it but it will only complain about it if there are other errors in the file. 

GCC will only complain about it if you pass it in the "positive" form. ie: -Wunknown-warning-option
$x86_64-pc-linux-gnu-gcc -Wunknown-warning-option /tmp/test.c
x86_64-pc-linux-gnu-gcc.real: error: unrecognized command line option ‘-Wunknown-warning-option’

And it will not complain in the negative form if there are no other errors in the file:
$ x86_64-pc-linux-gnu-gcc -Wno-unknown-warning-option /tmp/test.c
$ echo $?
0

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e8cf8cddbac9579a3280d9f55047dea739c1c951

commit e8cf8cddbac9579a3280d9f55047dea739c1c951
Author: Luis Lozano <llozano@chromium.org>
Date: Fri May 27 18:33:41 2016

Pass -Wno-unknown-warning-option option only to Clang.

I added -Wno-unknown-warning-option a week or so ago.
I thought this was a valid option for both Clang and GCC. It turns out it
is only supported by Clang. GCC does not support it but it will only
complain about it if there are other errors in the file.

GCC will only complain about it if you pass it in the "positive" form.
ie: -Wunknown-warning-option
$x86_64-pc-linux-gnu-gcc -Wunknown-warning-option /tmp/test.c
x86_64-pc-linux-gnu-gcc.real: error: unrecognized command line option -Wunknown-warning-option

And it will not complain in the negative form if there are no
other errors in the file:
$ x86_64-pc-linux-gnu-gcc -Wno-unknown-warning-option /tmp/test.c
$ echo $?
0

BUG= chromium:615466 
TEST=cbuildbot falco-release

Change-Id: I0b09415236b7a3edd985229c221fcdcb7325602f
Reviewed-on: https://chromium-review.googlesource.com/347699
Commit-Ready: Luis Lozano <llozano@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e8cf8cddbac9579a3280d9f55047dea739c1c951/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Status: Fixed (was: Untriaged)
Labels: VerifyIn-53
Blocking: 537368
Labels: VerifyIn-54

Comment 6 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

Sign in to add a comment