New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615464 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Stages which return False from WaitUntilReady Fail.

Project Member Reported by dgarr...@chromium.org, May 27 2016

Issue description

I used WaitUntilReady() in several stages, some of which fail to run under normal circumstances. For example, the SigningStage doesn't need to run if there are no signing requests for the board.

However, if WaitUntilReady returns false, a Failed result is recorded. Instead, we should SKIP the stage.


Discovered because of adityakali@google.com:

> Though it seems the lakitu_next-release builder started failing
> https://uberchromegw.corp.google.com/i/chromeos/builders/lakitu_next-release
> and the reason is unclear. Actually, only the 'cbuildbot' step is
>  marked as failed, but the image build and test and all other steps are 
> successful.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/60bbb488634ed3d5304a043530f6302129c6781e

commit 60bbb488634ed3d5304a043530f6302129c6781e
Author: Ningning Xia <nxia@chromium.org>
Date: Fri May 27 18:03:12 2016

Mark stages as skipped if WaitUntilReady returns False.

Mark stages as skipped instead of failed in results_lib.Results
and CIDB when WaitUntilReady returns False.

BUG= chromium:615464 
TEST=run_tests

Change-Id: I7a7c46ced58cb14e0477444379cc67f931ac8c29
Reviewed-on: https://chromium-review.googlesource.com/347519
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/60bbb488634ed3d5304a043530f6302129c6781e/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/60bbb488634ed3d5304a043530f6302129c6781e/cbuildbot/stages/generic_stages_unittest.py

Comment 2 by nxia@chromium.org, May 28 2016

Status: Fixed (was: Untriaged)
Closing... please feel free to reopen if its not fixed.
Status: Verified (was: Fixed)

Sign in to add a comment