New issue
Advanced search Search tips

Issue 615461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: User agent override with empty custom value is not clear

Project Member Reported by l...@chromium.org, May 27 2016

Issue description

1) Open Devtools, go to drawer
2) Open 'Network Conditions' tab
3) Uncheck 'Select automatically' and delete the text in the user agent input field

What is expected?
It's not clear what is sent when you leave the user agent field blank.  Does this not send any user agent header at all?  Does this send a user agent with value=""?

Today, it seems that value="" is interpreted as "keep sending the default user agent".  This could be made clearer with input placeholder text.
 

Comment 1 by l...@chromium.org, May 27 2016

Status: Started (was: Assigned)
Alternatively, we could add a red outline to indicate the empty value is invalid.
emptyua.png
17.3 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c0c5d499f1bbf5486b77fd15df03b39b5adf8b

commit 78c0c5d499f1bbf5486b77fd15df03b39b5adf8b
Author: luoe <luoe@chromium.org>
Date: Tue May 31 18:50:44 2016

DevTools: empty user agent validation

The red invalid outline should make it clear that an empty custom UA string
should not be allowed.

BUG= 615461 

Review-Url: https://codereview.chromium.org/2023483003
Cr-Commit-Position: refs/heads/master@{#396878}

[modify] https://crrev.com/78c0c5d499f1bbf5486b77fd15df03b39b5adf8b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/78c0c5d499f1bbf5486b77fd15df03b39b5adf8b/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css

Comment 3 by l...@chromium.org, Jun 22 2016

Status: Fixed (was: Started)

Sign in to add a comment