New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615454 link

Starred by 1 user
Status: Fixed
Owner:
mcasas@chromium.org
Closed: May 2016
Cc:
█ junov@chromium.org
fmalita@chromium.org
senorblanco@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 569976



Sign in to add a comment

HTML Video capture: prefer using SkSurface::MakeRaster

Project Member Reported by mcasas@chromium.org, May 27 2016 
...in HTMLVideoElementCapturerSource::StartCapture() [1]
|sk_sp<SkCanvas> canvas_| is initialized as

  canvas_ = sk_sp<SkCanvas>(skia::CreatePlatformCanvas(resolution.width,...

and instead we should prefer [2]
SkSurface::MakeRaster(...).getCanvas();


[1] https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/media/html_video_element_capturer_source.cc&sq=package:chromium&type=cs&l=94
[2] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/src/image/SkSurface_Raster.cpp&q=SkSurface::MakeRaster&sq=package:chromium&type=cs&l=193
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/277fb015119eb0970ae7bdcb0ec182b881477128

commit 277fb015119eb0970ae7bdcb0ec182b881477128
Author: mcasas <mcasas@chromium.org>
Date: Tue May 31 21:14:57 2016

HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see
https://crrev.com/2010173002

Also re-adding LayoutTest
HTMLMediaElementCapture-capture.html

BUG= 615454 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Review-Url: https://codereview.chromium.org/2018183002
Cr-Commit-Position: refs/heads/master@{#396932}

[modify] https://crrev.com/277fb015119eb0970ae7bdcb0ec182b881477128/content/renderer/media/html_video_element_capturer_source.cc
[modify] https://crrev.com/277fb015119eb0970ae7bdcb0ec182b881477128/content/renderer/media/html_video_element_capturer_source.h
[add] https://crrev.com/277fb015119eb0970ae7bdcb0ec182b881477128/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html

Comment 2 by mcasas@chromium.org, May 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment