New issue
Advanced search Search tips

Issue 615445 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

OOPIF: Trackpad scrolling not working on Chrome OS

Project Member Reported by creis@chromium.org, May 27 2016

Issue description

Version: 52.0.2743.0
OS: ChromeOS

What steps will reproduce the problem?
(1) Start Chrome with --isolate-extensions (using Dev Mode and command line, per https://www.chromium.org/chromium-os/poking-around-your-chrome-os-device).
(2) Install BeautifyFB extension: https://chrome.google.com/webstore/detail/beautify-fb/ldngjhkgckijklngngononnejmadojce
(3) Open the extension's options page.
(4) Try to scroll the Facebook iframe (should be an OOPIF) with two finger scroll on the trackpad.

What is the expected output?

The iframe should scroll.

What do you see instead?

It doesn't scroll with the trackpad, but does if you drag the scrollbars.

This was fixed on desktop in  issue 587023  (r393886), but somehow the fix doesn't seem to be working on ChromeOS.
 
Cc: dtapu...@chromium.org tdres...@chromium.org
It's possible that the trackpad gestures are managed differently on ChromeOS?

Comment 2 by kenrb@chromium.org, May 27 2016

I discussed this with dtapuska, and it isn't obvious what is wrong here. MouseWheel events work correctly on ChromeOS as on Linux. Trackpad scrolling works fine on a Macbook. This will need some debugging.

Comment 3 by kenrb@chromium.org, May 30 2016

Summary: OOPIF: Trackpad scrolling not working on Chrome OS (was: OOPIF: Scroll gestures not working on Chrome OS)

Comment 4 by creis@chromium.org, Jun 7 2016

Labels: -Pri-2 Proj-IsolateExtensions-BlockingLaunch M-53 Pri-1
Ken: I just confirmed that this bug still exists on 52.0.2743.19.  We should track down the cause to get it fixed for --isolate-extensions.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b678205722777a678aa0ae3a2610cae7a4efbce

commit 0b678205722777a678aa0ae3a2610cae7a4efbce
Author: kenrb <kenrb@chromium.org>
Date: Thu Jun 23 19:07:35 2016

Route ScrollEvents to correct process under OOPIF

On ChromeOS, trackpad scroll events are not routed to the an OOPIF
even when the mouse cursor is over one. This is because ScrollEvents
are transformed to WheelEvents and then passed directly to the
top-level frame's RenderWidgetHost, and don't use the path of other
WheelEvents that invokes the RenderWidgetHostInputEventRouter for
browser process hit testing.

This CL causes the events generated on reception of a ScrollEvent
by a RenderWidgetHostViewAura to be hit tested and sent to the
appropriate RenderWidgetHostView.

BUG= 615445 

Review-Url: https://codereview.chromium.org/2052353002
Cr-Commit-Position: refs/heads/master@{#401671}

[modify] https://crrev.com/0b678205722777a678aa0ae3a2610cae7a4efbce/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/0b678205722777a678aa0ae3a2610cae7a4efbce/content/browser/site_per_process_browsertest.cc

Comment 6 by kenrb@chromium.org, Jun 23 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
verified on 53.0.2785.15

Sign in to add a comment