Build is broken: message_center_unittests on Ubuntu-12.04 Revision range: chromium 396394 : 396407 Failing builders: Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1) Findit results: https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/13063#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d19388b6f1ca92183d28a7d4df9ceb9101309676 commit d19388b6f1ca92183d28a7d4df9ceb9101309676 Author: nednguyen <nednguyen@google.com> Date: Fri May 27 17:08:04 2016 Revert of Show message center on lock screen (patchset #2 id:120001 of https://codereview.chromium.org/1986493002/ ) Reason for revert: Speculative revert: this may cause message_center_unittests failure on Ubuntu-12.04 BUG= 615443 Original issue's description: > Show message center on lock screen > > This patch does: > - Show the message center button on tray on the lock screen > - Show the message to encourage user to log in when user opens message center on lock screen > - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. > - Don't make notifications read when opening the message center on lock screen > - Add tests > > And this patch also fixes the bug that this makes blocked notifications read wrongly. > > BUG= 599891 > TEST=manually tested > > Committed: https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 > Cr-Commit-Position: refs/heads/master@{#396402} TBR=dewittj@chromium.org,skuhne@chromium.org,yoshiki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 599891 Review-Url: https://codereview.chromium.org/2018063002 Cr-Commit-Position: refs/heads/master@{#396495} [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/fake_message_center.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/fake_message_center.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center_impl.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center_impl.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/message_center_observer.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/notification_list.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/notification_list.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/notification_list_unittest.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/views/message_center_view.h [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/d19388b6f1ca92183d28a7d4df9ceb9101309676/ui/strings/ui_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d827a875b4c7a0063dc63ed336d3fb08fc0faec commit 2d827a875b4c7a0063dc63ed336d3fb08fc0faec Author: yoshiki <yoshiki@chromium.org> Date: Tue May 31 04:58:15 2016 Reland: Show message center on lock screen The original CL (crrev.com/396402) was comitted but reverted (crrev.com/396495) due to MSAN failure (forgetting free the instance). This patch relands it with changing it with unique_ptr. BUG= 615443 TEST=MSAN bot passes TBR=dewittj@chromium.org, skuhne@chromium.org This patch does: - Show the message center button on tray on the lock screen - Show the message to encourage user to log in when user opens message center on lock screen - Add SetLockedState(bool) and IsLockedState() method into MessageCenter class. - Don't make notifications read when opening the message center on lock screen - Add tests And this patch also fixes the bug that this makes blocked notifications read wrongly. BUG= 599891 TEST=manually tested Committed: https://crrev.com/48c4b94a9d9eb0ae3a20ed9c05d9e77ff1a98b50 Cr-Commit-Position: refs/heads/master@{#396402} Review-Url: https://codereview.chromium.org/2025613002 Cr-Commit-Position: refs/heads/master@{#396785} [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/fake_message_center.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/fake_message_center.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center_impl.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center_impl.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/message_center_observer.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/notification_list.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/notification_list.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/notification_list_unittest.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/views/message_center_view.h [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/2d827a875b4c7a0063dc63ed336d3fb08fc0faec/ui/strings/ui_strings.grd
Comment 1 by nedngu...@google.com
, May 27 2016Labels: OS-Linux