bluetooth: Disconnect event is triggered after reconnect |
||||||||
Issue descriptionVersion 52.0.2743.0 dev (64-bit) Platform 8350.2.0 (Official Build) dev-channel link Firmware Google_Link.2695.1.169 What steps will reproduce the problem? (1) Go to https://googlechrome.github.io/samples/web-bluetooth/device-disconnect.html (2) Enter nearby BLE device name, click "Scan" button (3) Device is connected. (4) Click on "Disconnect" and quickly after "Reconnect" What is the expected output? Requesting Bluetooth Device... Connecting to Bluetooth Device... > Bluetooth Device connected Disconnecting from Bluetooth Device... > Bluetooth Device disconnected Connecting to Bluetooth Device... > Bluetooth Device connected What do you see instead? Requesting Bluetooth Device... Connecting to Bluetooth Device... > Bluetooth Device connected Disconnecting from Bluetooth Device... > Bluetooth Device disconnected Connecting to Bluetooth Device... > Bluetooth Device connected > Bluetooth Device disconnected <--------- WHY? And when I inspect bluetoothDevice.gatt.connected, it should be "true" instead of "false" as I reconnected afterwards.
,
May 30 2016
WIP at https://codereview.chromium.org/2016973003/ that fixes an issue in which we always disconnected a device even if the connection is still active.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775 commit bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775 Author: ortuno <ortuno@chromium.org> Date: Tue May 31 18:43:58 2016 bluetooth: Fix logic mistake in DeviceChanged Fixes an issue in which we always disconnected a device even if the connection is still active. BUG= 615383 Review-Url: https://codereview.chromium.org/2016973003 Cr-Commit-Position: refs/heads/master@{#396877} [modify] https://crrev.com/bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775/device/bluetooth/bluez/bluetooth_device_bluez.cc [modify] https://crrev.com/bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
,
May 31 2016
,
Jun 2 2016
,
Jun 2 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13db17e9c1703c1e7a84791817f616109e0fc5f3 commit 13db17e9c1703c1e7a84791817f616109e0fc5f3 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Jun 02 17:19:54 2016 bluetooth: Fix logic mistake in DeviceChanged Fixes an issue in which we always disconnected a device even if the connection is still active. BUG= 615383 Review-Url: https://codereview.chromium.org/2016973003 Cr-Commit-Position: refs/heads/master@{#396877} (cherry picked from commit bb0a85c376fc57c99d6b2e8df8af6ea5f8ab5775) Review URL: https://codereview.chromium.org/2032093002 . Cr-Commit-Position: refs/branch-heads/2743@{#191} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/13db17e9c1703c1e7a84791817f616109e0fc5f3/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/13db17e9c1703c1e7a84791817f616109e0fc5f3/device/bluetooth/bluez/bluetooth_device_bluez.cc [modify] https://crrev.com/13db17e9c1703c1e7a84791817f616109e0fc5f3/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
,
Jul 1 2016
,
Aug 12 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ortuno@chromium.org
, May 27 2016