DCHECK failure due to NewTabPage.Snippets.CardClickedAge |
||||||
Issue descriptionFrom android logs: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50
,
May 27 2016
,
May 27 2016
From https://code.google.com/p/chromium/codesearch#chromium/src/base/metrics/histogram.h&q=base::Histogram::FactoryGet&sq=package:chromium&type=cs&l=119: "For a valid histogram, input should follow these restrictions: minimum > 0 ..."
,
May 27 2016
Btw, please change histograms.xml units from "min" to "minutes".
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/861808d571c1a846d6df6f4d39f1f1cff54b45b0 commit 861808d571c1a846d6df6f4d39f1f1cff54b45b0 Author: jkrcal <jkrcal@chromium.org> Date: Wed Jun 01 06:03:55 2016 Fixing construction arguments for NewTabPage.Snippets.CardClickedAge I had different arguments in the code that the ones with which the histogram was constructed resulting in an error: F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50 BUG= 615379 Review-Url: https://codereview.chromium.org/2017013004 Cr-Commit-Position: refs/heads/master@{#397071} [modify] https://crrev.com/861808d571c1a846d6df6f4d39f1f1cff54b45b0/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
,
Jun 1 2016
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jkrcal@chromium.org
, May 27 2016Owner: jkrcal@chromium.org