New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 22 users
Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment
Regression:Font of text is not displayed properly in "hangouts.google.com"
Reported by adha...@etouch.net, May 27 2016 Back to list
Chrome Version:52.0.2743.11 (Official Build) 6b8610b195ce50e14827e3db8198dde414366705-refs/branch-heads/2743@{#96}(32/64-bit)
OS:Windows(7,8,8.1,10)

URL:https://hangouts.google.com/

What steps will reproduce the problem?
(1)Launch chrome,Navigate to above URl and Sign In with valid credentials.
(2)Open a chat window and click on "Attach a photo" icon.
(3)Now click on 'web camera' option and observe the text displayed.

Actual:Font of text is not displayed properly after clicking on 'web camera' option.

Expected:Font of text should be displayed properly after clicking on 'web camera' option.

This is Regression issue broken in M-51.

Good build:51.0.2670.0
Bad build:51.0.2671.0

ChangeLog info:
https://chromium.googlesource.com/chromium/src/+log/51.0.2670.0..51.0.2671.0?pretty=fuller&n=10000

Suspecting:r379622?

Kindly help to re-assign if your change is not the cause for this issue.

Note: 
(1)This issue is not seen on Mac and Linux.
(2)Unable to perform Flash bisect for above issue as issue is not playing in chromium build.

 
Actual.png
954 KB View Download
Expected.png
1.1 MB View Download
Comment 1 by adha...@etouch.net, May 27 2016
Cc: pbomm...@chromium.org
Components: Blink>Fonts
Comment 2 by tsepez@chromium.org, May 27 2016
Owner: lshang@chromium.org
Hangouts doesn't use PDF AFAIK, so not https://crrev.com/379622.
Guessing https://crrev.com/379681 based upon "camera" in step 3 above.
Comment 3 by lshang@chromium.org, May 30 2016
Owner: thakis@chromium.org
https://crrev.com/379681 is about mic and camera permission settings in chrome://settings/content, it's not related to hangouts, and the change is applied to all platforms(including linux, mac and win).

My guess is https://crrev.com/379678, based on 'win' in the CL description and it changed font related file.
Comment 4 by e...@chromium.org, Jun 1 2016
Cc: thakis@chromium.org
Components: -Blink>Fonts Internals>Plugins>Flash
Owner: ----
Status: Untriaged
Most likely r379589, blink now requires the embedding layer to pass in the font rendering style instead of always assuming ClearType on windows.

The Flash plugin likely needs to be updated to call the following methods with the desired settings:
  blink::WebFontRendering::setAntialiasedTextEnabled
  blink::WebFontRendering::setLCDTextEnabled

Over to Flash team for further action.

Comment 5 by msr.i...@gmail.com, Jun 5 2016
I have fixed this issue to add font anti-aliasing settings at content::PpapiPluginMain.
I would like to contribute, can I upload a patch?
Project Member Comment 6 by bugdroid1@chromium.org, Jun 10 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90d6c375486700b6965665189853549c96716efa

commit 90d6c375486700b6965665189853549c96716efa
Author: msr.i386 <msr.i386@gmail.com>
Date: Fri Jun 10 03:28:45 2016

Set text anti-aliasing settings at PPAPI plugin process on Windows.

This patch will enable text anti-aliasing to call the following methods:
* blink::WebFontRendering::setAntialiasedTextEnabled
* blink::WebFontRendering::setLCDTextEnabled

This patch will also get anti-aliasing settings from
gfx::GetFontRenderParams method.

BUG= 615375 
TEST=If [Smooth edges of screen fonts] at advanced system settings is
enabled, text in flash is anti-aliased. If disabled, text is aliased.

Review-Url: https://codereview.chromium.org/2048563004
Cr-Commit-Position: refs/heads/master@{#399073}

[modify] https://crrev.com/90d6c375486700b6965665189853549c96716efa/AUTHORS
[modify] https://crrev.com/90d6c375486700b6965665189853549c96716efa/content/ppapi_plugin/ppapi_plugin_main.cc

Project Member Comment 7 by bugdroid1@chromium.org, Jun 15 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90d6c375486700b6965665189853549c96716efa

commit 90d6c375486700b6965665189853549c96716efa
Author: msr.i386 <msr.i386@gmail.com>
Date: Fri Jun 10 03:28:45 2016

Set text anti-aliasing settings at PPAPI plugin process on Windows.

This patch will enable text anti-aliasing to call the following methods:
* blink::WebFontRendering::setAntialiasedTextEnabled
* blink::WebFontRendering::setLCDTextEnabled

This patch will also get anti-aliasing settings from
gfx::GetFontRenderParams method.

BUG= 615375 
TEST=If [Smooth edges of screen fonts] at advanced system settings is
enabled, text in flash is anti-aliased. If disabled, text is aliased.

Review-Url: https://codereview.chromium.org/2048563004
Cr-Commit-Position: refs/heads/master@{#399073}

[modify] https://crrev.com/90d6c375486700b6965665189853549c96716efa/AUTHORS
[modify] https://crrev.com/90d6c375486700b6965665189853549c96716efa/content/ppapi_plugin/ppapi_plugin_main.cc

Comment 8 by a...@chromium.org, Jun 17 2016
Labels: TE-Verified-53.0.2770.0 TE-Verified-M53
This is working fine on the latest canary(53.0.2770.0) on Windows-7. Attached is the screenshot of the same.

msr.i386@: Could you please get this merged to M-52.

Cc'ing reviewer's eae@ and piman@ as well for help in getting this merged to M-52.
615375.png
21.9 KB View Download
Comment 9 by a...@chromium.org, Jun 17 2016
Cc: e...@chromium.org piman@chromium.org
Comment 10 by a...@chromium.org, Jun 17 2016
 Issue 618112  has been merged into this issue.
Comment 11 by f...@opera.com, Jun 20 2016
Labels: Merge-Request-52
Comment 12 by tin...@google.com, Jun 20 2016
Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Owner: f...@opera.com
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member Comment 13 by bugdroid1@chromium.org, Jun 20 2016
Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d08547fe8beada518f8659ee9867cddfa440c8a

commit 1d08547fe8beada518f8659ee9867cddfa440c8a
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Jun 20 08:46:47 2016

Set text anti-aliasing settings at PPAPI plugin process on Windows.

This patch will enable text anti-aliasing to call the following methods:
* blink::WebFontRendering::setAntialiasedTextEnabled
* blink::WebFontRendering::setLCDTextEnabled

This patch will also get anti-aliasing settings from
gfx::GetFontRenderParams method.

BUG= 615375 
TEST=If [Smooth edges of screen fonts] at advanced system settings is
enabled, text in flash is anti-aliased. If disabled, text is aliased.

Review-Url: https://codereview.chromium.org/2048563004
Cr-Commit-Position: refs/heads/master@{#399073}
(cherry picked from commit 90d6c375486700b6965665189853549c96716efa)

Review URL: https://codereview.chromium.org/2081643002 .

Cr-Commit-Position: refs/branch-heads/2743@{#393}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/1d08547fe8beada518f8659ee9867cddfa440c8a/AUTHORS
[modify] https://crrev.com/1d08547fe8beada518f8659ee9867cddfa440c8a/content/ppapi_plugin/ppapi_plugin_main.cc

Comment 14 by f...@opera.com, Jun 20 2016
Cc: f...@opera.com
Owner: ----
Status: Fixed
Looks like the issue is still there on Windows 10 + 53.0.2770.0
[H28.06.19] Chrome Canary 53 Google Hangout Font.png
35.0 KB View Download
Comment 16 by role...@gmail.com, Jun 20 2016
Confirm to be fixed on Canary. Hope to see it come to stable release soon.
Chrome53.png
132 KB View Download
Comment 17 by f...@opera.com, Jun 20 2016
Status: Untriaged
Maybe I was too quick to resolve.
It still looks like ass. They need to add back GDI rendering.
chromesucks.png
39.9 KB View Download
Labels: TE-Verified-M52 TE-Verified-52.0.2743.49
Tested the issue on Windows 7 using 52.0.2743.49.Observed that font of text displayed properly after clicking on 'web camera' option.
Please find attached screenshot.

Marking it as TE-Verified-M52.
615375.png
22.6 KB View Download
Comment 20 by kojii@chromium.org, Jul 23 2016
Cc: rnimmagadda@chromium.org drott@chromium.org kojii@chromium.org ranjitkan@chromium.org
 Issue 615949  has been merged into this issue.
@ssamanoori could you please also verify on Windows 10 ? I see reports that the issue still reproduces on Windows 10 + M53 Canary ( see comment #15). It could be a regression on M53 but would be good to make sure Windows 10 works as well.  
Labels: Needs-Feedback
Able to reproduce the issue on Windows 10 using 52.0.2743.82, 53.0.2785.30, canary 54.0.2810.0.Observed that font of text is not displayed properly after clicking on 'web camera' option.

Please find attached screenshot.

adharap@: Could you please check the issue on Windows 10 and provide bisect information?
615375.png
124 KB View Download
I have a different observation than @ssamanoori : i'm not able to reproduce it on Windows 10 since Chrome 52 (52.0.2743.82 m 64bits).
This issue should be fixed by now. adharap@ Are you still able to reproduce?
Comment 25 by msr.i...@gmail.com, Aug 24 2016
I found that text antialiasing doesn't work when Win32k lockdown enabled.
win32klockdown.png
12.1 KB View Download
Comment 26 by e...@chromium.org, Aug 24 2016
Re 25: It doesn't appear to work for plugins but for all other content (I.e. the tab strip at the top of the camera window in the screenshot and the buttons below).
Owner: scottmg@chromium.org
Status: Started
I'm going to fiddle with this; the code that was added recently can't work during lockdown because it's trying to call SystemParametersInfo().

I noticed this because I was trying to fix crbug.com/258201 which will prevent HWNDs from being created in random processes and non-UI threads. At the moment this happens in the call to GetFontRenderParams(), as it tries to create a window to listen for changes to the settings, which also won't work.

I think I'll probably just pass the two values we need in on the ppapi command line. They won't update when the user switches the Windows-level setting until they reload the page, but it'll be better than what we have now at least.
Cc: ananta@chromium.org
DPI scale also won't be working per this: https://cs.chromium.org/chromium/src/content/ppapi_plugin/ppapi_plugin_main.cc?rcl=0&l=136
Project Member Comment 29 by bugdroid1@chromium.org, Sep 6 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e66b57781d08e764d749b5440c7e940bb3fc3700

commit e66b57781d08e764d749b5440c7e940bb3fc3700
Author: scottmg <scottmg@chromium.org>
Date: Tue Sep 06 20:30:43 2016

Fix antialiasing ppapi settings, browser_tests in win32k lockdown

PpapiPluginMain was calling font and dpi retrieval functions which
don't work in lockdown. Pass those values on the command line instead.

BUG=258201, 615375 

Review-Url: https://codereview.chromium.org/2306193002
Cr-Commit-Position: refs/heads/master@{#416704}

[modify] https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700/content/browser/ppapi_plugin_process_host.cc
[modify] https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700/content/ppapi_plugin/ppapi_plugin_main.cc
[modify] https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700/content/public/common/content_switches.cc
[modify] https://crrev.com/e66b57781d08e764d749b5440c7e940bb3fc3700/content/public/common/content_switches.h

Status: Fixed
I believe this should be fixed now, please confirm if possible.
Comment 31 by ara...@gmail.com, Nov 7 2016
I still have the issue with Windows 10 + Chrome 54.0.2840.71
Just tested this and another similar Flash-based issue in Windows 10 Chrome Version 54.0.2840.99 m, where it was not working and then onto trying it in Canary Version 57.0.2926.0 where both issues were fixed. Finally flash applications look normal again :) Thanks!
Sign in to add a comment