New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615374 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Localization is not applied for text 'Zoom' on Zoom bubble.

Reported by dchau...@etouch.net, May 27 2016

Issue description

Chrome Version: 53.0.2750.0 (Official Build) c84885e83ecac137b93ed2b6c8b7323d8e91ffe1-refs/heads/master@{#396337} 32/64-bit.
OS: Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome, change browser language to Hindi from 'chrome://settings/addLanguage' and restart the chrome.
2. Now zoom in/out the page using 'Ctrl' + '+/_' key from keyboard and observe the text 'Zoom' on zoom bubble.

Localization is not applied for text 'Zoom' on Zoom bubble.
Localization should applied for text 'Zoom' on Zoom bubble.

This is a regression issue, broken in M-53 series, below is bisect info.

Good build: 53.0.2748.0 
Bad build: 53.0.2750.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/3a2ec2d0eaff51be70260130163d3d96f66f9d97..945ea3ae79096e02e4a86dafc90e59a26609db59?pretty=fuller&n=100

Suspecting: r395841

Note: This issue is not seen on 'Mac' and 'Linux' OS.
 
bubble screenshot.png
12.1 KB View Download
Actual behavior.mp4
605 KB Download
Expected behavior.mp4
160 KB Download

Comment 1 Deleted

Comment 2 by glevin@chromium.org, May 27 2016

Yes, r395841 is the cause, and I believe that this is expected at the moment.  Because I changed the string used here
 https://codereview.chromium.org/1989563002/diff/60001/chrome/app/generated_resources.grd
the M-53 strings aren't yet retranslated, so it's defaulting to English.  Once the M-53 translations get done, this should be fixed automatically.  Note that this same problem is likely to occur with other strings associated with any of the bugs blocking Issue 475351.

The problem should also appear on Chrome OS.  Mac and Linux versions don't seem to provide the option to switch default language, which may be why it's not seen there...?

jshin@, does that all sound correct?  Also, do you know at what point in the release cycle string translation updating usually occurs?

Comment 3 by glevin@chromium.org, Jun 19 2016

Status: Fixed (was: Assigned)
Just tried this on 53.0.2773.0, seems to be working (see screenshot).  Assuming updated strings got translated.
Hindi_zoom.png
17.9 KB View Download

Sign in to add a comment