New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 615353 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to do operations when scale for menu and title bars is changed in displays settings of Ubuntu 14.04

Project Member Reported by sc00335...@techmahindra.com, May 27 2016

Issue description

Version: 52.0.2743.11 dev
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Open Displays in System settings of your desktop >> Launch chrome
(2) From Displays section Change Scale from "1" to "1.38" >> Now try clicking star icon in omnibox or try closing any tab or try clicking wrench menu

Expected: On changing the scale browser should be responsive to events.
Actual: Instead unable to click on close/wrench menu/star icon.

Note: After changing back the scale to "1" no hand pointer or text cursor is seen on any of the links/buttons or omnibox respectively. Only default mouse pointer is seen.

This is a regression issue broken in M52.

Good Build: 52.0.2715.0 dev
Bad Build: 52.0.2716.0 dev
 
Actual_titlebars.ogv
1.8 MB Download
Expected_titlebars.ogv
1.1 MB Download

Comment 1 by ajha@chromium.org, May 27 2016

Components: UI
Labels: ReleaseBlock-Beta
Status: Untriaged (was: Unconfirmed)
Able to reproduce this on the latest M-53(53.0.2750.0) on Linux Ubuntu 14.04 as well.

@Sindhu: Please update the bisect here.
Labels: -Needs-Bisect hasbisect
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
CHANGELOG URL:      
 https://chromium.googlesource.com/chromium/src/+log/a6c06f926e897df19c873bf5be07cd87d51b8c1b..7ba991af2ed157f2c8ef8ad1855bfaa620f34da6

Suspecting https://codereview.chromium.org/1907103002 from changelog

@thomasanderson: Please confirm the issue and help in re-assigning if it is not related to your change.
Cc: thestig@chromium.org e...@chromium.org osh...@chromium.org est...@chromium.org
Owner: osh...@chromium.org
I can confirm that this problem started occuring at change https://codereview.chromium.org/1907103002

This change appears to expose an existing issue in chrome.  It appears we blacklist scale factors > 130% here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/libgtk2ui/gtk2_ui.cc&sq=package:chromium&l=1391

This is why it works with a scale factor of 1.25 but not 1.38.  Passing to oshima (a reviewer of the commit from the git-blame).
Cc: thomasanderson@chromium.org

Comment 5 by osh...@chromium.org, May 27 2016

Labels: -Pri-1 Pri-2
Chrome currently requires restart when DSF changes. This has been this way, and I don't have time to change this behavior. I can change it so that it always use the same scale for its lifetime.
That sounds like a good fix to me.
This issue is marked as Beta blocker, please resolve asap. 

M52 will be promoted to Beta on 06/01, please have the fix baked in canary and merged to 2743 branch before 05/30 Monday.
Issue still reproduced on latest M 53 i.e. 53.0.2753.0 and 52.0.2743.19.

thomasanderson/oshima : Could you please take a look into this and update further.
oshima@ Are you making the change described in #5 ?

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Status: Started (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52c96f45954fb726585acd0bac295d801728b22e

commit 52c96f45954fb726585acd0bac295d801728b22e
Author: oshima <oshima@chromium.org>
Date: Wed Jun 01 17:30:28 2016

Keep using the same DPI scale

* Dynamic DSF change is not supported/tested on linux. Jus make sure that it uses the same scale unless restarted.

BUG= 615353 
R=thomasanderson@chromium.org

Review-Url: https://codereview.chromium.org/2022383002
Cr-Commit-Position: refs/heads/master@{#397171}

[modify] https://crrev.com/52c96f45954fb726585acd0bac295d801728b22e/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

Labels: Merge-Request-52
Do you think the CL is safe to be merged before baking in canary?
This does not seem to be super urgent (as restarting chrome fixes), so we can wait a bit more.
Great, we will verify in today's canary and update the thread.

Comment 17 by tin...@google.com, Jun 2 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 2 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee319470677620e163b9406ca2fc2743c9c2c344

commit ee319470677620e163b9406ca2fc2743c9c2c344
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Thu Jun 02 21:40:35 2016

Keep using the same DPI scale

* Dynamic DSF change is not supported/tested on linux. Jus make sure that it uses the same scale unless restarted.

BUG= 615353 
R=thomasanderson@chromium.org

Review-Url: https://codereview.chromium.org/2022383002
Cr-Commit-Position: refs/heads/master@{#397171}
(cherry picked from commit 52c96f45954fb726585acd0bac295d801728b22e)

Review URL: https://codereview.chromium.org/2036693003 .

Cr-Commit-Position: refs/branch-heads/2743@{#199}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/ee319470677620e163b9406ca2fc2743c9c2c344/chrome/browser/ui/libgtk2ui/gtk2_ui.cc

Checked the issue on 53.0.2757.0 dev ,Ubuntu 14.04 and is working fine.i.e; Able to click on close/wrench menu/star icon after changing scale to 1.38.

Labels: TE-Verified-M53 TE-Verified-53.0.2757.0
thanks for the update.

Tested the issue on Linux Ubuntu 14.04 using chrome version 53.0.2757.0.able to click on ment and star icons after changing the scale factor from 1 to 1.38
Adding TE-Verified label.

Thnaks,
If there is no pending work, could you please mark as fixed.
Status: Fixed (was: Started)
Labels: TE-Verified-52.0.2743.33 TE-Verified-M52
Tested the issue on Ubuntu 14.04 using 52.0.2743.33.Observed that on changing the scale factor from 1 to 1.38, able to click on close/wrench menu/star icon.

Marking it as TE-Verified-M52.

Sign in to add a comment