Views Textfields: Inserted text is not selected on Undo. |
|||||||||||
Issue descriptionVersion: 53.0.2748.0 OS: All What steps will reproduce the problem? (1) Open bookmark bubble by clicking the star icon to the right of the address bar. (2) Type "abcdef" in the Name: textfield. (3) Select "def" and press Backspace. (4) Press Ctrl+Z to undo. What is the expected output? The text should be "abcdef" with "def" selected. What do you see instead? The text is "abcdef" with cursor after 'f'.
,
May 27 2016
Undoing an action should restore whatever the selection was prior to the undone action. So in the case of undoing a backspace as in comment 0, the restored text should be selected iff it was selected before pressing backspace. Similarly with the case in comment 1.
,
Jan 27 2017
,
Jan 27 2017
,
Mar 9 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 29 2018
I'll take this since we need it for MacViews
,
Mar 29 2018
,
Mar 29 2018
,
May 16 2018
,
May 18 2018
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39f2467ad15b66d6e4dd1714f405d4aefa3c9aca commit 39f2467ad15b66d6e4dd1714f405d4aefa3c9aca Author: Tessa Nijssen <tnijssen@google.com> Date: Thu May 24 00:39:32 2018 [Views] Added Selection on Undo Previously, after a section of text was removed and the removal was undone, the cursor was placed after the text. The desired behavior would be a selection of the re-placed text. This change saves the current selection range on delete or replace. The selection range is then restored on undo. Changed tests: - TextfieldModelTest.UndoRedo_CutCopyPasteTest - OmniboxViewTest.UndoRedo Added tests: - TextfieldModelTest.Undo_SelectionTest Bug: 615345 Change-Id: I9ce001099de7175da688a993ed3bfd29d296660c Reviewed-on: https://chromium-review.googlesource.com/1066675 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561338} [modify] https://crrev.com/39f2467ad15b66d6e4dd1714f405d4aefa3c9aca/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/39f2467ad15b66d6e4dd1714f405d4aefa3c9aca/ui/views/controls/textfield/textfield_model.cc [modify] https://crrev.com/39f2467ad15b66d6e4dd1714f405d4aefa3c9aca/ui/views/controls/textfield/textfield_model.h [modify] https://crrev.com/39f2467ad15b66d6e4dd1714f405d4aefa3c9aca/ui/views/controls/textfield/textfield_model_unittest.cc
,
May 24 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by karandeepb@chromium.org
, May 27 2016