Regression: In chrome://history weird overlapping is seen on search field
Reported by
rk...@etouch.net,
May 27 2016
|
|||
Issue descriptionChrome Version: 53.0.2750.0 Revision c84885e83ecac137b93ed2b6c8b7323d8e91ffe1-refs/heads/master@{#396337}(32/64 bit) OS: Windows(7,8,9), Mac(10.10.5)(10.11.5) Pre-condition:Enable Material Design history from chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://history page. (2) Press Tab key upto focus reaches to search field and type something, observe weird overlapping is seen in search field and also close button is not clickable. No such overlapping should seen in search field. This is a regression issue, broken in 'M-53' , below is bisect info: Good Build: 53.0.2749.0 Bad Build: 53.0.2750.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/ef7aca16ba536b6e3b4d4ca2c7d60ef547f44267..2f51b95ab526d0bac7b08ed525ec51e27850c119?pretty=fuller&n=50 Suspecting: r396115 Note: will soon update the Linux OS info.
,
May 30 2016
Ideal behavior: Focusing the search field with tab shows a cursor, and as soon as a key is pressed the search field opens as if it was clicked. This is similar to how Inbox works.
,
Jun 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9c8d5807f65c1040a4f2121b4904bb7014be12b commit e9c8d5807f65c1040a4f2121b4904bb7014be12b Author: tsergeant <tsergeant@chromium.org> Date: Wed Jun 01 04:04:31 2016 MD WebUI: Improve tab focus behavior for toolbar search field In wide mode, ensure the input field gets focus rather than the search icon when tabbing. The toolbar will only expand when the user starts typing. BUG= 615318 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2025583002 Cr-Commit-Position: refs/heads/master@{#397049} [modify] https://crrev.com/e9c8d5807f65c1040a4f2121b4904bb7014be12b/chrome/test/data/webui/cr_elements_browsertest.js [modify] https://crrev.com/e9c8d5807f65c1040a4f2121b4904bb7014be12b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html [modify] https://crrev.com/e9c8d5807f65c1040a4f2121b4904bb7014be12b/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js [modify] https://crrev.com/e9c8d5807f65c1040a4f2121b4904bb7014be12b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html [modify] https://crrev.com/e9c8d5807f65c1040a4f2121b4904bb7014be12b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
,
Jun 2 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rk...@etouch.net
, May 27 2016