New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 615312 link

Starred by 2 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
mac-bugs-priority@chromium.org
pkasting@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 547953



Sign in to add a comment

Regression:Outline for info bar is not displayed if any theme is installed.

Reported by vku...@etouch.net, May 27 2016 
Chrome Version:52.0.2743.11 (Official Build)Revision 6b8610b195ce50e14827e3db8198dde414366705-refs/branch-heads/2743@{#96} (64-bit)
OS:Mac(10.10.5)(10.11.5)

What steps will reproduce the problem?
1.Launch chrome and install any theme from https://chrome.google.com/webstore/category/themes?hl=en
2.Observe the info bar once theme is installed.

Actual: Outline for info bar is not displayed once theme is installed.

Expected: Outline for info bar should be displayed once any theme is installed.

This is a regression issue broken in "M52" and will soon update other info.

Comment 1 by vku...@etouch.net, May 27 2016

Labels: -OS-Windows hasbisect
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression:Outline for info bar is not displayed if any theme is installed. (was: Regression:Outline for info bar is not displayed once theme is installed.)
Manual regression range:
Good Build: 52.0.2742.0
Bad Build: 52.0.2743.11

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/6b693cb69c1731ac3e4fa0851e64fd10fa820a1c..003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68?pretty=fuller&n=30

Suspecting: r394885

Note: Issue not seen on Win & Linux OS.
Actual_Theme.png
330 KB View Download
Expected_Theme.png
330 KB View Download

Comment 2 by ashej...@chromium.org, May 27 2016

Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this needs to fixed before M52 goes to stable.

Feel free to remove if someone thinks otherwise.

Thank you!

Comment 3 by shrike@chromium.org, May 27 2016

Blocking: 547953
Labels: Proj-MaterialDesign-NativeUI

Comment 4 by durga.behera@chromium.org, May 31 2016 

Just to update issue still seen on canary 53.0.2753.0.

Comment 5 by shrike@chromium.org, Jun 2 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91226de4de99cf0d7b87b48ddabbb7affcb246e6

commit 91226de4de99cf0d7b87b48ddabbb7affcb246e6
Author: shrike <shrike@chromium.org>
Date: Thu Jun 02 18:21:07 2016

[Mac][Material Design] Fix regression with infobar border.

This cl fixes a regression where infobars no longer displayed their
border.

R=avi@chromium.org
BUG= 615312 

Review-Url: https://codereview.chromium.org/2029893002
Cr-Commit-Position: refs/heads/master@{#397473}

[modify] https://crrev.com/91226de4de99cf0d7b87b48ddabbb7affcb246e6/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm

Comment 7 by vku...@etouch.net, Jun 3 2016 

Just to update:

Above issue seems to be fixed in latest canary version 53.0.2757.0

Thank you.

Comment 8 by msrchandra@chromium.org, Jun 3 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2757.0
Adding TE-Verified labels as per Comment# 7.
Thank You.

Comment 9 by shrike@chromium.org, Jun 3 2016

Labels: Merge-Request-52

Comment 10 by tin...@google.com, Jun 3 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 3 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56da2bdd424b6a6ffc11ee17a83d2b29570ff0c0

commit 56da2bdd424b6a6ffc11ee17a83d2b29570ff0c0
Author: Jayson Adams <shrike@chromium.org>
Date: Fri Jun 03 23:12:43 2016

[Mac][Material Design] Fix regression with infobar border.

This cl fixes a regression where infobars no longer displayed their
border.

R=avi@chromium.org
BUG= 615312 

Review-Url: https://codereview.chromium.org/2029893002
Cr-Commit-Position: refs/heads/master@{#397473}
(cherry picked from commit 91226de4de99cf0d7b87b48ddabbb7affcb246e6)

Review URL: https://codereview.chromium.org/2032143005 .

Cr-Commit-Position: refs/branch-heads/2743@{#220}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/56da2bdd424b6a6ffc11ee17a83d2b29570ff0c0/chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm

Comment 12 by shrike@chromium.org, Jun 6 2016

Status: Fixed (was: Started)

Comment 13 by msrchandra@chromium.org, Jun 8 2016

Labels: TE-Verified-52.0.2743.33 TE-Verified-M52
Verified the issue on Chrome Beta# 52.0.2743.33 on Mac OS X 10.11.4 and is working as intended. Adding screenshot for reference.
Adding TE-Verified labels as well.
Thank You.
►

Sign in to add a comment